-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Score Normalization and Combination feature #241
Merged
martin-gaievski
merged 12 commits into
opensearch-project:main
from
martin-gaievski:feature/normalization
Aug 3, 2023
Merged
Added Score Normalization and Combination feature #241
martin-gaievski
merged 12 commits into
opensearch-project:main
from
martin-gaievski:feature/normalization
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add main classes for Query along with basic unit tests Signed-off-by: Martin Gaievski <gaievski@amazon.com>
* Add integ and unit test for query Signed-off-by: Martin Gaievski <gaievski@amazon.com> --------- Signed-off-by: Martin Gaievski <gaievski@amazon.com>
…ect#198) * Add doc collector Signed-off-by: Martin Gaievski <gaievski@amazon.com>
* Add query phase searcher and basic tests Signed-off-by: Martin Gaievski <gaievski@amazon.com> --------- Signed-off-by: Martin Gaievski <gaievski@amazon.com>
* Adding hybrid_search_enabled settings Signed-off-by: Martin Gaievski <gaievski@amazon.com>
…search-project#227) * Adding search processor for score normalization and combination Signed-off-by: Martin Gaievski <gaievski@amazon.com>
* Adding weights param for combination technique Signed-off-by: Martin Gaievski <gaievski@amazon.com>
* Adding L2 norm technique Signed-off-by: Martin Gaievski <gaievski@amazon.com>
* Add harmonic mean combination Signed-off-by: Martin Gaievski <gaievski@amazon.com>
* Add geometric mean normalization for scores Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
changed the title
Added Hybrid Search feature
Added Score Normalization and Combination feature
Aug 3, 2023
martin-gaievski
added
Features
Introduces a new unit of functionality that satisfies a requirement
v2.10.0
Issues targeting release v2.10.0
backport 2.x
Label will add auto workflow to backport PR to 2.x branch
labels
Aug 3, 2023
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
force-pushed
the
feature/normalization
branch
from
August 3, 2023 19:00
108fc9f
to
dbaa1c9
Compare
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
============================================
- Coverage 89.55% 86.23% -3.32%
- Complexity 103 337 +234
============================================
Files 7 28 +21
Lines 316 981 +665
Branches 52 153 +101
============================================
+ Hits 283 846 +563
- Misses 16 69 +53
- Partials 17 66 +49
|
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen and
zane-neo
as code owners
August 3, 2023 19:12
navneet1v
approved these changes
Aug 3, 2023
naveentatikonda
approved these changes
Aug 3, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-241-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 61e6e98bb6377d95d1043e1c4adcc0d4309b99ac
# Push it to GitHub
git push --set-upstream origin backport/backport-241-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
martin-gaievski
added a commit
that referenced
this pull request
Aug 3, 2023
* Added Score Normalization and Combination feature Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 61e6e98)
martin-gaievski
added a commit
to martin-gaievski/neural-search
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Label will add auto workflow to backport PR to 2.x branch
Features
Introduces a new unit of functionality that satisfies a requirement
v2.10.0
Issues targeting release v2.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Score Normalization and Combination feature, that includes Hybrid Query and Normalization processor for Search Result. This is merge PR, that includes following PRs from feature branch:
Issues Resolved
#123
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.