-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Added Score Normalization and Combination feature, manual backport #263
Merged
martin-gaievski
merged 4 commits into
opensearch-project:2.x
from
martin-gaievski:backport/backport-hybrid-search-to-2.x
Aug 25, 2023
Merged
[Backport 2.x] Added Score Normalization and Combination feature, manual backport #263
martin-gaievski
merged 4 commits into
opensearch-project:2.x
from
martin-gaievski:backport/backport-hybrid-search-to-2.x
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
the
Maintenance
Add support for new versions of OpenSearch/Dashboards from upstream
label
Aug 25, 2023
martin-gaievski
changed the title
Backport/backport hybrid search to 2.x
[Backport 2.x] Added Score Normalization and Combination feature, manual backport
Aug 25, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #263 +/- ##
============================================
- Coverage 89.55% 86.29% -3.27%
- Complexity 103 340 +237
============================================
Files 7 29 +22
Lines 316 992 +676
Branches 52 153 +101
============================================
+ Hits 283 856 +573
- Misses 16 70 +54
- Partials 17 66 +49
|
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
force-pushed
the
backport/backport-hybrid-search-to-2.x
branch
from
August 25, 2023 20:05
9ab2aef
to
19a321c
Compare
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
August 25, 2023 20:13
martin-gaievski
removed
the
Maintenance
Add support for new versions of OpenSearch/Dashboards from upstream
label
Aug 25, 2023
navneet1v
approved these changes
Aug 25, 2023
naveentatikonda
approved these changes
Aug 25, 2023
vibrantvarun
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport base PRs related to Hybrid Search feature. One is base big PR, last two are small and only related to feature flag name. Commits history is preserved from
main
branchMain PR with porting from feature branch:
61e6e98 from #241
Fix feature flag apporach:
5819df6 from #246
2a9f70a from #247
what is not included:
PR with fixes after testing: #259, it will be done in separate PR.