Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Added Score Normalization and Combination feature, manual backport #263

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Aug 25, 2023

Description

Backport base PRs related to Hybrid Search feature. One is base big PR, last two are small and only related to feature flag name. Commits history is preserved from main branch

Main PR with porting from feature branch:
61e6e98 from #241

Fix feature flag apporach:
5819df6 from #246

2a9f70a from #247

what is not included:

PR with fixes after testing: #259, it will be done in separate PR.

…#241)

* Added Score Normalization and Combination feature

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit 61e6e98)
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit 5819df6)
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit 2a9f70a)
@martin-gaievski martin-gaievski added the Maintenance Add support for new versions of OpenSearch/Dashboards from upstream label Aug 25, 2023
@martin-gaievski martin-gaievski changed the title Backport/backport hybrid search to 2.x [Backport 2.x] Added Score Normalization and Combination feature, manual backport Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #263 (19a321c) into 2.x (5228fc7) will decrease coverage by 3.27%.
Report is 6 commits behind head on 2.x.
The diff coverage is 84.11%.

@@             Coverage Diff              @@
##                2.x     #263      +/-   ##
============================================
- Coverage     89.55%   86.29%   -3.27%     
- Complexity      103      340     +237     
============================================
  Files             7       29      +22     
  Lines           316      992     +676     
  Branches         52      153     +101     
============================================
+ Hits            283      856     +573     
- Misses           16       70      +54     
- Partials         17       66      +49     
Files Changed Coverage Δ
...earch/neuralsearch/ml/MLCommonsClientAccessor.java 92.00% <ø> (ø)
...nsearch/neuralsearch/query/NeuralQueryBuilder.java 89.01% <ø> (+1.09%) ⬆️
...nsearch/neuralsearch/query/HybridQueryBuilder.java 72.64% <72.64%> (ø)
...lsearch/search/query/HybridQueryPhaseSearcher.java 73.58% <73.58%> (ø)
...ensearch/neuralsearch/query/HybridQueryWeight.java 76.00% <76.00%> (ø)
...euralsearch/search/HybridTopScoreDocCollector.java 79.62% <79.62%> (ø)
...earch/processor/normalization/ScoreNormalizer.java 80.00% <80.00%> (ø)
...ensearch/neuralsearch/query/HybridQueryScorer.java 81.25% <81.25%> (ø)
...r/normalization/L2ScoreNormalizationTechnique.java 83.33% <83.33%> (ø)
...neuralsearch/processor/NormalizationProcessor.java 83.87% <83.87%> (ø)
... and 16 more

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski force-pushed the backport/backport-hybrid-search-to-2.x branch from 9ab2aef to 19a321c Compare August 25, 2023 20:05
@martin-gaievski martin-gaievski marked this pull request as ready for review August 25, 2023 20:13
@martin-gaievski martin-gaievski removed the Maintenance Add support for new versions of OpenSearch/Dashboards from upstream label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants