Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated manifests for OpenSearch 2.x need custom JAVA_HOME #2044

Closed
dblock opened this issue Apr 27, 2022 · 5 comments
Closed

Generated manifests for OpenSearch 2.x need custom JAVA_HOME #2044

dblock opened this issue Apr 27, 2022 · 5 comments
Assignees
Labels
enhancement New Enhancement

Comments

@dblock
Copy link
Member

dblock commented Apr 27, 2022

Is your feature request related to a problem? Please describe

Automation opened a PR to generate the OpenSearch 3.0 manifest. That manifest was missing JAVA_HOME that was added manually in #2042.

Describe the solution you'd like

Add a way to customize generated manifests for various products/versions, add JAVA_HOME to the OpenSearch ones.

Describe alternatives you've considered

Keep doing it manually.

Additional context

No response

@dblock dblock added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Apr 27, 2022
@peterzhuamazon
Copy link
Member

We just need the manifest workflow to add this line for OpenSearch BE.
The problem being we can only default to the highest java version tho.

@dblock
Copy link
Member Author

dblock commented Apr 27, 2022

There's some hard-coding going on in

def create_manifest(self, version: str, components: List = []) -> InputManifest:
that will need refactoring.

@prudhvigodithi
Copy link
Member

[Triage] just a thought since the the build container already has multiple java versions added, we might need to add an entry to manifest file that has JDK version specification, just like we have one for checks:, so that way each component can use the desired java version that is passed, if not it will go withe default JDK version.

@zelinh
Copy link
Member

zelinh commented Jul 20, 2022

Instead of hard-coding both image_map, jdk_version and data: Dict = ..., we are looking into an alternative way to auto generate the manifest with those data. As @dblock suggested here, I will be trying to create such template manifest folders and have the new manifest loading those infos depending on the product and version. If it doesn't have certain template, we will use hard-coded default value.

@gaiksaya
Copy link
Member

gaiksaya commented Aug 1, 2022

Closing via #2358

@gaiksaya gaiksaya closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants