Add Java home argument to the manifest workflow

[zelinh]

Description

Add Java home argument to the manifest workflow based on the manifest version. If it's 1.x (in our case 1.3.x primarily), it will add jdk 11 argument. If it's 2.x or 3.x, it will add jdk 17 for now. Otherwise, it will set to jdk17 by default.

Issues Resolved

#2044

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #2354 (e94faf4) into main (858dc0e) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2354      +/-   ##
============================================
+ Coverage     94.61%   94.94%   +0.32%     
============================================
  Files           209      157      -52     
  Lines          4309     4134     -175     
  Branches         29       19      -10     
============================================
- Hits           4077     3925     -152     
+ Misses          226      209      -17     
+ Partials          6        0       -6     

Impacted Files	Coverage Δ
src/manifests_workflow/input_manifests.py	98.98% <100.00%> (+0.01%)	⬆️
tests/jenkins/jobs/UploadTestResults_Jenkinsfile
...ests/jenkins/jobs/AssembleManifest_rpm_Jenkinsfile
src/jenkins/InputManifest.groovy
...bs/PrintArtifactDownloadUrlsForStaging_Jenkinsfile
...tifactsQualifier_OpenSearch_Dashboards_Jenkinsfile
tests/jenkins/jobs/SignArtifacts_Jenkinsfile
...sts/jenkins/jobs/DetectTestDockerAgent_Jenkinsfile
...ests/jenkins/jobs/AssembleManifest_tar_Jenkinsfile
tests/jenkins/jobs/BuildYumRepo_Jenkinsfile
... and 43 more

[dblock]

This is going to start adding JDK args into OpenSearch Dashboards' manifests as well, which is certainly not desired.

I think you need to do something more elaborate. Instead of hard-coding both image_map and data: Dict = ... maybe create a folder structure with templates and load those depending on the product and version being built, falling back to a default that doesn't have anything in it?

manifests/templates/opensearch/main/manifest.yml
manifests/templates/opensearch/2.x/manifest.yml
manifests/templates/opensearch-dashboards/main/manifest.yml

Another alternative would be to look for the previous version of the manifest, and copy image and args from there. Maybe simpler?

Finally, if you do go the hard-coded route, create a map of maps to split up OS and OSD.

[zelinh]

This is going to start adding JDK args into OpenSearch Dashboards' manifests as well, which is certainly not desired.

I think you need to do something more elaborate. Instead of hard-coding both image_map and data: Dict = ... maybe create a folder structure with templates and load those depending on the product and version being built, falling back to a default that doesn't have anything in it?

manifests/templates/opensearch/main/manifest.yml
manifests/templates/opensearch/2.x/manifest.yml
manifests/templates/opensearch-dashboards/main/manifest.yml

Another alternative would be to look for the previous version of the manifest, and copy image and args from there. Maybe simpler?

Finally, if you do go the hard-coded route, create a map of maps to split up OS and OSD.

oops you are right. I didn't think about about the dashboard situation. I will close this PR for now and dive into the solution you propose. Thanks.