Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated 3.0.0 manifest with JAVA_HOME arguement #2042

Merged
merged 1 commit into from
Apr 27, 2022
Merged

updated 3.0.0 manifest with JAVA_HOME arguement #2042

merged 1 commit into from
Apr 27, 2022

Conversation

joshpalis
Copy link
Member

Signed-off-by: Joshua Palis jpalis@amazon.com

Description

Distribution build pipelines using the OpenSearch 3.0.0 manifest fail since JAVA_HOME is not set within the node. I've added this argument to the 3.0.0 manifest, mirroring the 2.0.0 manifest

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Palis <jpalis@amazon.com>
@joshpalis joshpalis added the bug Something isn't working label Apr 27, 2022
@joshpalis joshpalis requested a review from a team as a code owner April 27, 2022 01:06
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #2042 (bb7a052) into main (dcfc3f0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2042   +/-   ##
=========================================
  Coverage     94.23%   94.23%           
  Complexity       25       25           
=========================================
  Files           198      198           
  Lines          3902     3902           
  Branches         29       29           
=========================================
  Hits           3677     3677           
  Misses          219      219           
  Partials          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcfc3f0...bb7a052. Read the comment docs.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also opened #2044

@dblock dblock merged commit cbe0f12 into opensearch-project:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants