-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation for component release issue creation #3708
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3708 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 182 182
Lines 5420 5420
=======================================
Hits 4962 4962
Misses 458 458 |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
One thought is, usually when a release manager creates an issue, they get notifications when someone comments on it with any component related update. But now, since bot it creating the issues it would be difficult to get notified. Maybe we can include the name of the release manager (by tagging) in someway so that they get notified too? |
I agree with this point, one way is during runtime an RM can inject his token to ensure the issues are created with an RM username but again this would be a manual step, the change of workflow through this PR adds a link of main release issue (part of the build repo) to all the component release issues, having this GitHub should link the component release issues to main issue and an RM can follow up from there. |
@bbarani @peterzhuamazon @dblock please add your thoughts. |
If this works it LGTM, although @gaiksaya comment is very valid. Consider contributing the feature you need to dblock/create-a-github-issue? Or at least opening an issue? |
Thanks @dblock I have just opened one dblock/create-a-github-issue#71. |
Thanks I will merge this for now as it removes the manual effort to create releases issues across multiple repos, we can always come back and modify as required. |
I dint knew GitHub has 256 hard limit. When I execute I get the following error. I have tested on my local with 4-5 of my fork repos, but when added all the release OS and OSD component repos and matrix combination of all the manifests part of the manifest folder its exceeding more than 256.
More information: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymatrix |
Description
Automation for component release issue creation
Create a release issue in build repo this logic is same using the action
dblock/create-a-github-issue@v3.0.0
. Using matrix for each repo and version creates an issue in components/plugins repo usingpeter-evans/create-issue-from-file@v4
, the actiondblock/create-a-github-issue@v3.0.0
does not support cross repo issue creation.Using
actions-cool/issues-helper@v3
to identify if an issue already exists as by default thepeter-evans/create-issue-from-file@v4
does not have this logic (related open issue: peter-evans/create-issue-from-file#298).The
dblock/create-a-github-issue@v3.0.0
has the logic to avoid creation of duplicate issues (search_existing: all
) but does not work in creating issues for cross repo.Hence the combination of all works better in creating a release issue in build repo and component release issue in plugins repo.
The step
Replace placeholders
updates thecomponent_release_template.md
file with right versions before creating a component release issue.Note: This creates the main release issue and component release issues but it wont update the component section markdown table of the main release issue.
Sample Testing:
Sample Run:
Sample Component Issue: prudhvigodithi/job-scheduler#23
Skipping for non major/minor version: (Logic used is to check if the last digit
endsWith
with.0
)Issues Resolved
Part of:
#3349
#3676
opensearch-project/.github#167
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.