Adding orchestrator pipeline and refactoring testsuite job #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2021 14:49
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
1 task
Codecov Report
@@ Coverage Diff @@
## main #523 +/- ##
=======================================
Coverage 69.65% 69.65%
=======================================
Files 59 59
Lines 1575 1575
=======================================
Hits 1097 1097
Misses 478 478 Continue to review full report at Codecov.
|
Comment on lines
+24
to
+32
| PerfTests: { | ||
| build job: 'perf-test', | ||
| parameters: [ | ||
| string(name: 'opensearch_version', value: "${params.opensearch_version}"), | ||
| string(name: 'build_id', value: "${params.build_id}"), | ||
| string(name: 'architecture', value: "${params.architecture}"), | ||
| string(name: 'test_run_id', value: "${TEST_RUN_ID}") | ||
| ] | ||
| }, |
There was a problem hiding this comment.
- Do we want to get this in even though the job doesn't exist? I would prefer to hold off if this piece of code is un-used.
- Do we know if these params are good for perf test?
There was a problem hiding this comment.
- I have added a perf-test job in staging. The perf-test logic can be updated independent of the orchestrator DSL so it should be fine. Let me know if you have a strong preference otherwise.
- These common params should be good. The configurations around which rally tests to run can be part of the
opensearch-buildrepo as code, similar to the test_manifest.yml config. Keeping the DSL simple and uniform will help avoid the need for frequent jenkins deployments.
There was a problem hiding this comment.
Sure, if we have a strong sense that this is the code I am good with it.
Feels like it is :)
Signed-off-by: Himanshu Setia <setiah@amazon.com>
saratvemulapalli
approved these changes
Sep 17, 2021
owaiskazi19
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the DSL for orchestration pipeline and refactors the testsuite job to identify test-suite type based on the jenkins job name
Signed-off-by: Himanshu Setia setiah@amazon.com
Issues Resolved
#262
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.