[GUIDE] Add document_lifecycle guide #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zethuman
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
zethuman
changed the title
|
@zethuman I think you'll have easier time doing this: In the end you'll have one nice PR for all the guides. I think it's faster than fixing DCO in every PR. WDYT? |
zethuman
force-pushed
the
feature/guides/document_lifecycle
branch
from
f11952d to
fa32f4d
Compare
* Add linter for markdown files Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Updated CHANGELOG.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Add make-script and update DEVELOPER_GUIDE.md Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Updated linter options Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> * Fixed mmarkdown files format Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com> --------- Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
…t#272) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
…ensearch-project#286) Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com> Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
force-pushed
the
feature/guides/document_lifecycle
branch
from
fa32f4d to
d3a8912
Compare
|
Yes, I thought about it, but it's probably more a matter of principle... |
|
AFAIK this is the only other Guide where the go code is not indented correctly. |
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
force-pushed
the
feature/guides/document_lifecycle
branch
from
3004ed4 to
d586aa2
Compare
|
@Jakob3xD add indented go code |
Signed-off-by: Rakhat Zhuman <zhumanrakhat01@gmail.com>
zethuman
force-pushed
the
feature/guides/document_lifecycle
branch
from
bc6898b to
f34da71
Compare
dblock
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add document_lifecycle guide.
Issues Resolved
Closes [#276, #279].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.