ApacheHttpClient5Transport requires Apache Commons Logging dependency #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
commented
May 27, 2024
| @@ -169,6 +169,7 @@ dependencies { | |||
| val jacksonDatabindVersion = "2.17.0" | |||
|
|
|||
| // Apache 2.0 | |||
| api("commons-logging:commons-logging:1.3.2") | |||
There was a problem hiding this comment.
This dependency is coming from opensearch-rest-client transitively, making it a mandatory one since it is also needed by Apache HttpClient 5 transport.
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock
approved these changes
May 28, 2024
reta
added a commit
to reta/opensearch-java
that referenced
this pull request
May 28, 2024
…opensearch-project#1003) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ApacheHttpClient5Transport requires Apache Commons Logging dependency
Issues Resolved
Closes #1002
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.