Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApacheHttpClient5Transport requires Apache Commons Logging dependency #1003

Merged
merged 1 commit into from
May 28, 2024
Merged

ApacheHttpClient5Transport requires Apache Commons Logging dependency #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ This section is for maintaining a changelog for all breaking changes for the cli
### Removed

### Fixed
- ApacheHttpClient5Transport requires Apache Commons Logging dependency ([#1003](https://github.com/opensearch-project/opensearch-java/pull/1003))

### Security

Expand Down
1 change: 1 addition & 0 deletions java-client/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ dependencies {
val jacksonDatabindVersion = "2.17.0"

// Apache 2.0
api("commons-logging:commons-logging:1.3.2")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is coming from opensearch-rest-client transitively, making it a mandatory one since it is also needed by Apache HttpClient 5 transport.

compileOnly("org.opensearch.client", "opensearch-rest-client", opensearchVersion)
testImplementation("org.hamcrest:hamcrest:2.2")
testImplementation("com.carrotsearch.randomizedtesting:randomizedtesting-runner:2.8.1") {
Expand Down
Loading