fix: remove required check on indices.stats.ShardStats.shards #1177
+213
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiamMacpherson
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
LiamMacpherson
commented
Sep 2, 2024
java-client/src/main/java/org/opensearch/client/opensearch/indices/stats/ShardStats.java
Outdated
Show resolved
Hide resolved
dblock
previously requested changes
Sep 2, 2024
java-client/src/main/java/org/opensearch/client/opensearch/indices/stats/ShardStats.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Sep 6, 2024
java-client/src/main/java/org/opensearch/client/opensearch/indices/stats/ShardStats.java
Show resolved
Hide resolved
LiamMacpherson
force-pushed
the
main
branch
from
2c5205c
to
93ebd81
Compare
LiamMacpherson
force-pushed
the
main
branch
from
93ebd81
to
cb89246
Compare
Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com>
Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com>
Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com>
Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com>
Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com>
Xtansia
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Thanks for sticking with this @LiamMacpherson, the changes look good, just need to fix the formatting to keep the CI happy.
Could you please run and commit the changes:
./gradlew spotlessApplySigned-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com>
|
Ah -- I hadn't noticed that failure! Thanks for highlighting @Xtansia! |
Xtansia
approved these changes
Sep 17, 2024
|
Thanks @LiamMacpherson |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1177-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8a37f3f2776f5ef2244382c6bc379747e05f203e
# Push it to GitHub
git push --set-upstream origin backport/backport-1177-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
Xtansia
pushed a commit
to Xtansia/opensearch-java
that referenced
this pull request
Sep 17, 2024
…arch-project#1177) * fix: remove required check on indices.stats.ShardStats.shards Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * address review comments re: imports and changelog Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * add test and remove check in constructor Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * re-remove auto import organisation Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * chore: correct changelog link Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * spotlessApply tidyup Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> --------- Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> (cherry picked from commit 8a37f3f)
dblock
pushed a commit
that referenced
this pull request
Sep 17, 2024
…#1200) * fix: remove required check on indices.stats.ShardStats.shards Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * address review comments re: imports and changelog Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * add test and remove check in constructor Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * re-remove auto import organisation Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * chore: correct changelog link Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * spotlessApply tidyup Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> --------- Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> (cherry picked from commit 8a37f3f) Co-authored-by: Liam Macpherson <LiamMacpherson42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change addresses the problem wherein we require a field which isn't ever returned inside the "Shards" property on indices stats calls with the level set to "shards".
Issues Resolved
Closes 1174
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.