[Backport 2.x] fix: remove required check on indices.stats.ShardStats.shards (#1177) #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch-project#1177) * fix: remove required check on indices.stats.ShardStats.shards Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * address review comments re: imports and changelog Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * add test and remove check in constructor Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * re-remove auto import organisation Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * chore: correct changelog link Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> * spotlessApply tidyup Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> --------- Signed-off-by: Liam Macpherson <Liam.Macpherson@sas.com> Signed-off-by: Liam Macpherson <LiamMacpherson42@gmail.com> (cherry picked from commit 8a37f3f)
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports #1177 to 2.x
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.