Replace non unicode with ASCII character #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
changed the title
|
@VijayanB The root cause of this problem seems to be that the javadoc character encoding is sometimes set to ASCII, if you look in OpenSearch its explicitly set to UTF-8. Can we make a similar change in this libraries build.gradle? If we want to enforce the ASCII character set, then I'd recommend changing the approval steps in this repo to block PRs that contain non-ASCII characters |
|
@peternied Thanks for feedback. I created an issue here #50 We will update unicode setting like OpenSearch, shall we merge this to unblock 1.0.0 maven release since it prevents jenkins to publish to maven local? |
imRishN
pushed a commit
to imRishN/opensearch-java
that referenced
this pull request
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Description
Replace unmappable character (0xE2) for encoding US-ASCII. This was causing issue in infra vm
while building javadoc.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.