Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing SafeConstructor() now that Snakeyml has been bumped up to 2.0 #504

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

joshpalis
Copy link
Member

Description

Now that OpenSearch has bumped up SnakeYaml version to 2.0 we can remove SafeConstructor()

Issues Resolved

Coming from : opensearch-project/OpenSearch#6511

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Palis <jpalis@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #504 (bb32b93) into main (f5f65e6) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main     #504   +/-   ##
=========================================
  Coverage     66.50%   66.50%           
  Complexity      187      187           
=========================================
  Files            35       35           
  Lines           821      821           
  Branches         24       24           
=========================================
  Hits            546      546           
  Misses          264      264           
  Partials         11       11           
Impacted Files Coverage Δ
...ain/java/org/opensearch/sdk/ExtensionSettings.java 82.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@owaiskazi19 owaiskazi19 merged commit cfa34eb into opensearch-project:main Mar 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 1, 2023
Signed-off-by: Joshua Palis <jpalis@amazon.com>
(cherry picked from commit cfa34eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Mar 1, 2023
(cherry picked from commit cfa34eb)

Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants