Initialize SDKClient with instance of ExtensionSettings #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
Kuanysh-kst
requested review from
joshpalis,
owaiskazi19,
ryanbogan,
saratvemulapalli and
dbwiddis
as code owners
Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #579 +/- ##
============================================
+ Coverage 69.85% 69.92% +0.06%
Complexity 216 216
============================================
Files 40 40
Lines 889 891 +2
Branches 26 26
============================================
+ Hits 621 623 +2
Misses 257 257
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dbwiddis
previously approved these changes
Mar 16, 2023
Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
dbwiddis
approved these changes
Mar 16, 2023
owaiskazi19
reviewed
Mar 18, 2023
owaiskazi19
approved these changes
Mar 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Created the MapperExtension interface and added the MapperPlugin content Signed-off-by: Kuanysh <kuanysh4646@gmail.com> * deleted comments Signed-off-by: Kuanysh <kuanysh4646@gmail.com> * add javadoc Signed-off-by: Kuanysh <kuanysh4646@gmail.com> * add unit test Signed-off-by: Kuanysh <kuanysh4646@gmail.com> * refactor for unit test Signed-off-by: Kuanysh <kuanysh4646@gmail.com> * refactor Signed-off-by: Kuanysh <kuanysh4646@gmail.com> * add constructor SDKClient, change methods, change tests Signed-off-by: Kuanysh <kuanysh4646@gmail.com> * refactor Signed-off-by: Kuanysh <kuanysh4646@gmail.com> * refactor for gradle check Signed-off-by: Kuanysh <kuanysh4646@gmail.com> * refactor for parametrs and comments Signed-off-by: Kuanysh <kuanysh4646@gmail.com> --------- Signed-off-by: Kuanysh <kuanysh4646@gmail.com> (cherry picked from commit 7e4cf0b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.