Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [CCI] logo_opensearch.js file is hardcoded #602

Closed
SergeyMyssak opened this issue Mar 17, 2023 · 2 comments
Closed

[BUG] [CCI] logo_opensearch.js file is hardcoded #602

SergeyMyssak opened this issue Mar 17, 2023 · 2 comments
Labels
bug Something isn't working CCI College Contributor Initiative

Comments

@SergeyMyssak
Copy link
Collaborator

Describe the bug

In #380 OpenSearch logo has been added. As far as I understood, logo_opensearch.js file was written manually because when we run compile-icons command, this file is updated and has different content.

To Reproduce
Steps to reproduce the behavior:

  1. yarn compile-icons
  2. Check changes in logo_opensearch.js

Expected behavior
logo_opensearch.js file should not be updated when running yarn compile-icons command

Screenshots

Screenshot 2023-03-17 at 10 42 27

Host/Environment (please complete the following information):

  • OS: macOS Ventura 13.2
  • Browser and version: N/A
@SergeyMyssak SergeyMyssak added bug Something isn't working untriaged labels Mar 17, 2023
SergeyMyssak added a commit to SergeyMyssak/oui that referenced this issue Mar 17, 2023
@SergeyMyssak
Update logo_opensearch.js file (opensearch-project#602)
7b44628 
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
SergeyMyssak added a commit to SergeyMyssak/oui that referenced this issue Mar 17, 2023
@SergeyMyssak
Update logo_opensearch.js file (opensearch-project#602)
bb52cb9 
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
@SergeyMyssak SergeyMyssak mentioned this issue Mar 17, 2023
Merged
6 tasks
@KrooshalUX KrooshalUX added the CCI College Contributor Initiative label Mar 17, 2023
@ashwin-pc
Copy link
Member

Nice catch!

SergeyMyssak added a commit to SergeyMyssak/oui that referenced this issue Mar 18, 2023
@SergeyMyssak
Update logo_opensearch.js file (opensearch-project#602)
1bf4bb2 
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
ashwin-pc pushed a commit that referenced this issue Mar 22, 2023
@SergeyMyssak
Update logo_opensearch.js file (#602) (#603)
ab8f480 
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Mar 22, 2023
@github-actions
Update logo_opensearch.js file (#602) (#603)
fd94267 
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
(cherry picked from commit ab8f480)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Mar 22, 2023
@github-actions
Update logo_opensearch.js file (#602) (#603)
e73b458 
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
(cherry picked from commit ab8f480)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BSFishy
Copy link
Contributor

BSFishy commented Mar 22, 2023

PR has been merged into main 👍

@BSFishy BSFishy closed this as completed Mar 22, 2023
joshuarrrr pushed a commit that referenced this issue Mar 23, 2023
@opensearch-trigger-bot @github-actions
Update logo_opensearch.js file (#602) (#603) (#614)
851abb1 
(cherry picked from commit ab8f480)

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this issue Mar 23, 2023
@opensearch-trigger-bot @github-actions
Update logo_opensearch.js file (#602) (#603) (#617)
3fd3b73 
(cherry picked from commit ab8f480)

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@seanneumann seanneumann moved this to Done in Look & Feel May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CCI College Contributor Initiative
Projects
Look & Feel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BSFishy @SergeyMyssak @ashwin-pc @KrooshalUX