[CCI] Update logo_opensearch.js file #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin-pc
reviewed
Mar 17, 2023
Comment on lines
16
to
18
| width={32} | ||
| height={32} | ||
| fill="none" |
There was a problem hiding this comment.
The width and height were removed because they are missing in the original icon. Can you update the accompanying svg tag with the width and height?
<svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" viewBox="0 0 64 64" fill="none">There was a problem hiding this comment.
Thanks for the comment, it's done!
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
SergeyMyssak
force-pushed
the
602-Update-logo-opensearch-file
branch
from
bb52cb9 to
1bf4bb2
Compare
ashwin-pc
approved these changes
Mar 21, 2023
|
Thanks for the change @SergeyMyssak! its these smaller things that slip through the cracks. Thanks again for finding it. |
BSFishy
approved these changes
Mar 21, 2023
|
@ashwin-pc would you say this can be backported to |
|
@BSFishy Yes it can since the svg file is not exported as is. Its compiles down to the typescript file which the actual export. That has not changed here. |
joshuarrrr
pushed a commit
that referenced
this pull request
Mar 23, 2023
(cherry picked from commit ab8f480) Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Mar 23, 2023
(cherry picked from commit ab8f480) Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
logo_opensearch.jsfile has been regenerated using theyarn compile-iconscommand.Issues Resolved
#602
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.