Deprecation of Master nomenclature #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaushal Kumar <kshkmr@amazon.com> Signed-off-by: Kaushal Kumar <kshkmr@amazon.com>
* version increment automation Signed-off-by: pgodithi <pgodithi@amazon.com> * version increment automation Signed-off-by: pgodithi <pgodithi@amazon.com> Signed-off-by: Kaushal Kumar <kshkmr@amazon.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@amazon.com> Co-authored-by: Sagar Upadhyaya <sagar.upadhyaya.121@amazon.com> Signed-off-by: Kaushal Kumar <kshkmr@amazon.com>
kaushalmahi12
changed the title
kkhatua
suggested changes
Aug 16, 2022
| @@ -21,7 +21,7 @@ | |||
| "max-flow-units-per-vertex-buffer": 200, | |||
|
|
|||
| "tags": { | |||
| "locus": "idle-master-node" | |||
| "locus": "cluster_manager-node" | |||
There was a problem hiding this comment.
I think this is correct. Because there is another file called rca_idle_cluster_manager where the locus has value as "idle-cluster_manager-node".
| @@ -789,16 +789,17 @@ public String toString() { | |||
| } | |||
|
|
|||
| public static class Constants { | |||
| public static final String PENDING_TASKS_COUNT_VALUE = "Master_PendingQueueSize"; | |||
| public static final String PENDING_TASKS_COUNT_VALUE = | |||
| "ClusterManager_PendingQueueSize"; | |||
| public static final String sElectionTermPath = "election_term"; | ||
| public static final String sHttpPath = "http"; | ||
| public static final String sOSPath = "os_metrics"; | ||
| public static final String sHeapPath = "heap_metrics"; | ||
| public static final String sNodesPath = "node_metrics"; | ||
| public static final String sPendingTasksPath = "pending_tasks"; | ||
| public static final String sMasterThrottledTasksPath = "master_throttling_metrics"; | ||
| public static final String sClusterManagerThrottledTasksPath = | ||
| "cluster_manager_throttling_metrics"; |
Signed-off-by: Kaushal Kumar <kshkmr@amazon.com>
kaushalmahi12
force-pushed
the
IDE_compliant_change
branch
from
c8b37ce to
38af297
Compare
dzane17
reviewed
Aug 17, 2022
| @@ -54,8 +54,8 @@ jobs: | |||
| - name: Checkout Performance Analyzer | |||
| uses: actions/checkout@v2 | |||
| with: | |||
| repository: opensearch-project/performance-analyzer | |||
| ref: main | |||
| repository: kaushalmahi12/performance-analyzer | |||
There was a problem hiding this comment.
Is this PA repository & ref change temporary?
|
I will break the commit into smaller ones and raise the PR against those. It will help the reviewers to review the changes without getting tired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Master Nomenclature Issue
Describe the solution you are proposing
This change is to stop the usage of
masterkeyword in the performance-analyzer-rca codebase.Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.