rename master to cluster_manager commit_4 #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaushal Kumar <kshkmr@amazon.com>
kaushalmahi12
requested review from
a team,
dzane17,
kkhatua,
sgup432 and
sruti1312
5 tasks
sruti1312
approved these changes
Aug 23, 2022
Comment on lines
+125
to
+126
| Paths.get(rcaEnabledFileLoc.toString(), "rca_cluster_manager.conf").toString(), | ||
| Paths.get(rcaEnabledFileLoc.toString(), "rca_elected_cluster_manager.conf") |
There was a problem hiding this comment.
note: these config files need to be renamed as well. Hopefully they are covered in the other PR's
| put(2, HostTag.STANDBY_MASTER_1); | ||
| put(0, HostTag.ELECTED_CLUSTER_MANAGER); | ||
| put(1, HostTag.STANDBY_CLUSTER_MANAGER_0); | ||
| put(2, HostTag.STANDBY_CLUSTER_1); |
There was a problem hiding this comment.
nit: STANDBY_CLUSTER_MANAGER_1
There was a problem hiding this comment.
Noted. Will make the change
| STANDBY_MASTER_1, | ||
| // The STANDBY_CLUSTER_MANAGER_X tags are only used in dedicated cluster_manager node clusters. | ||
| STANDBY_CLUSTER_MANAGER_0, | ||
| STANDBY_CLUSTER_1, |
There was a problem hiding this comment.
nit: STANDBY_CLUSTER_MANAGER_1
There was a problem hiding this comment.
Noted. Will make the change
|
Leaving the parent PR open. Need to add bwc in parent PR post that parent PR will be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kaushal Kumar kshkmr@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Master Nomenclature Issue
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
This PR is one of few That I will create against the issue mentioned in the description. There is parent PR which is open but too long to review at once.