Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-code OpenSearch dependency to 1.1.0 #248

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 8, 2021

Signed-off-by: dblock dblock@dblock.org

Description

In thinking about how to fix opensearch-project/opensearch-build#1266 this is another alternative to #249. Since there's no opensearch-min 1.1.1 the patch for dashboards-reports uses 1.1.0 build tools.

Issues Resolved

opensearch-project/opensearch-build#1266

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@dblock.org>
@dblock
Copy link
Member Author

dblock commented Dec 8, 2021

@peterzhuamazon which one do you prefer?

@dblock dblock marked this pull request as ready for review December 8, 2021 18:10
@dblock
Copy link
Member Author

dblock commented Dec 8, 2021

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

zhongnansu
zhongnansu previously approved these changes Dec 8, 2021
@davidcui1225
Copy link
Contributor

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

I think that failure was fixed by a PR yesterday that was merged to the main branch but not 1.1, is that correct @joshuali925

@peterzhuamazon
Copy link
Member

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

I think that failure was fixed by a PR yesterday that was merged to the main branch but not 1.1, is that correct @joshuali925

That is most likely caused by apt not updated.

* Update apt source in CI

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Try fix link checker

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@zhongnansu
Copy link
Member

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

I think that failure was fixed by a PR yesterday that was merged to the main branch but not 1.1, is that correct @joshuali925

I am not sure how to resolve the dashboards build failure, help? /cc: @kavilla

apt update command is added in this PR to main #245

@dblock
Copy link
Member Author

dblock commented Dec 8, 2021

cherry-picked 9f4fb7b on top of this

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@peterzhuamazon peterzhuamazon merged commit d33924f into opensearch-project:1.1 Dec 8, 2021
@dblock dblock deleted the 1.1.1-fixes branch December 8, 2021 21:53
kavilla pushed a commit to kavilla/dashboards-reports that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants