Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-code OpenSearch dependency to 1.1.0 (alternative) #249

Closed
wants to merge 2 commits into from

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 8, 2021

Signed-off-by: dblock dblock@dblock.org

Description

In thinking about how to fix opensearch-project/opensearch-build#1266 this is another alternative to #248.

Issues Resolved

opensearch-project/opensearch-build#1266

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@dblock.org>
Signed-off-by: dblock <dblock@dblock.org>
@codecov-commenter
Copy link

Codecov Report

Merging #249 (90a45c0) into 1.1 (aea039a) will decrease coverage by 10.73%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##                1.1     #249       +/-   ##
=============================================
- Coverage     64.15%   53.42%   -10.74%     
  Complexity      309      309               
=============================================
  Files           102       69       -33     
  Lines          4383     2454     -1929     
  Branches        658      277      -381     
=============================================
- Hits           2812     1311     -1501     
+ Misses         1403      978      -425     
+ Partials        168      165        -3     
Flag Coverage Δ
dashboards-reports ?
reports-scheduler 53.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboards-reports/server/utils/validationHelper.ts
...ards-reports/public/components/main/main_utils.tsx
...port_definitions/report_trigger/report_trigger.tsx
...itions/report_trigger/report_trigger_constants.tsx
dashboards-reports/server/routes/utils/helpers.ts
...shboards-reports/public/components/utils/utils.tsx
dashboards-reports/test/httpMockClient.js
...eports/public/components/utils/settings_service.ts
...t_definition_details/report_definition_details.tsx
dashboards-reports/server/model/backendModel.ts
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea039a...90a45c0. Read the comment docs.

@dblock
Copy link
Member Author

dblock commented Dec 8, 2021

@peterzhuamazon which one do you prefer?

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Dec 8, 2021

Closed because: opensearch-project/opensearch-build#1266 (comment)
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants