Fixed logic to get all alerts for a detector

[amsiglan]

Description

The total_alerts count of getAlerts API is capped at 10000, so we cannot rely on that count to find the total number of alerts. As a mitigation, the logic has been refactored to fetch alerts until we get less than 10k alerts which would mean there are no more alerts remaining.

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[AWSHurneyt]

Not blocking, but can we create an issue in the alerting/SAP backend repo to track fixing the getAlerts API response, and provide a link to that issue in this comment? That will help track when we should refactor this frontend code.

[amsiglan]

@riysaxen-amzn Can you create an issue in backend and reference this PR there? Thanks!

[AWSHurneyt]

Changes LGTM; approving assuming CI passes.

[amsiglan]

UTs passed locally -

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.24%. Comparing base (4faedfe) to head (2a51e46).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   31.25%   31.24%   -0.01%     
==========================================
  Files         159      159              
  Lines        5283     5278       -5     
  Branches      981      980       -1     
==========================================
- Hits         1651     1649       -2     
+ Misses       3458     3455       -3     
  Partials      174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-965-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03d3b1494f55dbc57934970ab80db3dbe0239fa3
# Push it to GitHub
git push --set-upstream origin backport-965-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-965-to-2.x.

[opensearch-trigger-bot]

The backport to 2.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.13
# Create a new branch
git switch --create backport-965-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03d3b1494f55dbc57934970ab80db3dbe0239fa3
# Push it to GitHub
git push --set-upstream origin backport-965-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.13

Then, create a pull request where the base branch is 2.13 and the compare/head branch is backport-965-to-2.13.

[opensearch-trigger-bot]

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.11
# Create a new branch
git switch --create backport-965-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03d3b1494f55dbc57934970ab80db3dbe0239fa3
# Push it to GitHub
git push --set-upstream origin backport-965-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport-965-to-2.11.

[opensearch-trigger-bot]

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-analytics-dashboards-plugin/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/security-analytics-dashboards-plugin/backport-2.12
# Create a new branch
git switch --create backport-965-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03d3b1494f55dbc57934970ab80db3dbe0239fa3
# Push it to GitHub
git push --set-upstream origin backport-965-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-analytics-dashboards-plugin/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport-965-to-2.12.