[2.x] Backport missing commits from #924, #942, #965 #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rule editor enhancements Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated test snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * relax validation for author name and description Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added validation for level, status, log type in yaml editor Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fix rule creation with empty or undefined Id Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
…e tables (opensearch-project#942) * fetching all findings using the pagination query params; optimized api calls for alert flyout, correlations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fetching all alerts; updated correlations UI Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments; updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
riysaxen-amzn
approved these changes
Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #966 +/- ##
==========================================
+ Coverage 31.04% 31.24% +0.20%
==========================================
Files 157 159 +2
Lines 5248 5278 +30
Branches 986 980 -6
==========================================
+ Hits 1629 1649 +20
- Misses 3432 3455 +23
+ Partials 187 174 -13 ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
* Rule editor enhancements (#924) * rule editor enhancements Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated test snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * relax validation for author name and description Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added validation for level, status, log type in yaml editor Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fix rule creation with empty or undefined Id Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Fetch all findings and alerts for the detectors when displaying in the tables (#942) * fetching all findings using the pagination query params; optimized api calls for alert flyout, correlations Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fetching all alerts; updated correlations UI Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments; updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed logic to get all alerts (#965) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit a683e9c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Mar 22, 2024
* Rule editor enhancements (#924) * rule editor enhancements * updated test snapshots * relax validation for author name and description * added validation for level, status, log type in yaml editor * fix rule creation with empty or undefined Id * fixed cypress tests --------- * Fetch all findings and alerts for the detectors when displaying in the tables (#942) * fetching all findings using the pagination query params; optimized api calls for alert flyout, correlations * fetching all alerts; updated correlations UI * addressed PR comments; updated snapshots --------- * fixed logic to get all alerts (#965) --------- (cherry picked from commit a683e9c) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport missing commits from #924, #942, #965
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.