Skip to content

Commit

Permalink
Disable codecov from failing CI if there is an upload issue (#3353)
Browse files Browse the repository at this point in the history
### Description
Seeing a ton of CI failures due to code coverage upload failures. I'd
like to fix this - but I'd rather keep the builds flowing in until we
have a better solution.

E.g:
https://github.com/opensearch-project/security/actions/runs/6153593099/job/16697726519?pr=3339

- Related #2649

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 6d78bce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
github-actions[bot] committed Sep 18, 2023
1 parent c00ddd0 commit 568bd4b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
action: codecov/codecov-action@v3
with: |
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
fail_ci_if_error: false
files: ./build/reports/jacoco/test/jacocoTestReport.xml
- uses: actions/upload-artifact@v3
Expand Down

0 comments on commit 568bd4b

Please sign in to comment.