Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Code Coverage is broken #2649

Closed
peternied opened this issue Apr 5, 2023 · 5 comments · Fixed by #3537 or #3668
Closed

[BUG] Code Coverage is broken #2649

peternied opened this issue Apr 5, 2023 · 5 comments · Fixed by #3537 or #3668
Labels
bug Something isn't working CCI College Contributor Initiative good first issue These are recommended starting points for newcomers looking to make their first contributions. help wanted Community contributions are especially encouraged for these issues. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@peternied
Copy link
Member

What is the bug?
Code coverage is being uploaded on pull requests due to errors:

{'detail': ErrorDetail(string='Missing "owner" argument. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

JDK11 build [Source]

{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

JDK17 build [Source]

What is the expected behavior?
Looks like our github action is uses: codecov/codecov-action@v1 this is deprecated and should be replaced with v3 - see details from https://github.com/codecov/codecov-action#%EF%B8%8F--deprecation-of-v1
@peternied peternied added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized good first issue These are recommended starting points for newcomers looking to make their first contributions. help wanted Community contributions are especially encouraged for these issues. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Apr 5, 2023
@stephen-crawford
Copy link
Contributor

[Triage] Hi @peternied, thank you for taking the time to file this issue. I see you labelled this as a good first issue, and we definitely agree. Thank you.

@stephen-crawford stephen-crawford added CCI College Contributor Initiative triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. labels Apr 10, 2023
@peternied peternied mentioned this issue Sep 13, 2023
Merged
3 tasks
willyborankin pushed a commit that referenced this issue Sep 13, 2023
@peternied
Disable codecov from failing CI if there is an upload issue (#3353)
6d78bce 
### Description
Seeing a ton of CI failures due to code coverage upload failures. I'd
like to fix this - but I'd rather keep the builds flowing in until we
have a better solution.

E.g:
https://github.com/opensearch-project/security/actions/runs/6153593099/job/16697726519?pr=3339

- Related #2649

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Peter Nied <petern@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Sep 18, 2023
@github-actions
Disable codecov from failing CI if there is an upload issue (#3353)
568bd4b 
### Description
Seeing a ton of CI failures due to code coverage upload failures. I'd
like to fix this - but I'd rather keep the builds flowing in until we
have a better solution.

E.g:
https://github.com/opensearch-project/security/actions/runs/6153593099/job/16697726519?pr=3339

- Related #2649

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 6d78bce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@peternied peternied mentioned this issue Oct 25, 2023
Merged
3 tasks
@peternied
Copy link
Member Author

Looks like this wasn't fixed, taking another attempt to fix this

@peternied peternied reopened this Nov 8, 2023
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Nov 8, 2023
@peternied peternied mentioned this issue Nov 8, 2023
Merged
3 tasks
stephen-crawford pushed a commit that referenced this issue Nov 10, 2023
@peternied
Fix the association of code coverage results with source code (#3668)
b504ca4 
### Description
Fix the association of code coverage results with source code. You'll
have seen how this was broken because we stopped getting the comment on
PRs with coverage information. My apologies for breaking this in the
most recent change to centralized the CC runs.

### Issues Resolved
- Resolves #2649

### Testing
✅ Inspection CC report on this PR, see
[[link]](#3668 (comment)).

### Check List
- [ ] ~New functionality includes testing~
- [ ] ~New functionality has been documented~
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied reopened this Nov 10, 2023
@peternied
Copy link
Member Author

Going to keep this opened until the backport [1] is created and merged into 2.x

@stephen-crawford
Copy link
Contributor

Just FYI, I did not actually close this on you, I think it auto closed when I merged that PR @peternied

@stephen-crawford stephen-crawford removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label Nov 13, 2023
@peternied peternied self-assigned this Jan 9, 2024
@peternied peternied mentioned this issue Jan 9, 2024
Closed
3 tasks
@peternied peternied removed their assignment Jan 23, 2024
@peternied
Copy link
Member Author

I haven't seen failures on CC in the past several days, and the PR I had out wasn't making any difference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CCI College Contributor Initiative good first issue These are recommended starting points for newcomers looking to make their first contributions. help wanted Community contributions are especially encouraged for these issues. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
2 participants
@peternied @stephen-crawford