Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Java Native Access Description in THIRD-PARTY.txt #2107

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Correct Java Native Access Description in THIRD-PARTY.txt #2107

merged 1 commit into from
Sep 27, 2022

Conversation

stephen-crawford
Copy link
Contributor

@stephen-crawford stephen-crawford commented Sep 26, 2022

Description

Documentation change to reflect use of GA JNA in THIRD-PARTY.txt document. No behavioral changes just documentation correctness.

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@stephen-crawford stephen-crawford requested a review from a team September 26, 2022 16:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #2107 (ab4adfe) into main (1fc02ad) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2107      +/-   ##
============================================
- Coverage     60.97%   60.96%   -0.02%     
+ Complexity     3226     3224       -2     
============================================
  Files           256      256              
  Lines         18073    18073              
  Branches       3224     3224              
============================================
- Hits          11020    11018       -2     
- Misses         5475     5476       +1     
- Partials       1578     1579       +1     
Impacted Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 35.75% <0.00%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, happy to merge this change once the DCO has been included in the commit message.

See the failed check for DCO link for how to resolve this issue.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @scrawfor99!

@peternied peternied merged commit 2a00e2b into opensearch-project:main Sep 27, 2022
@cwperks cwperks added the backport 2.x backport to 2.x branch label Sep 27, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 27, 2022
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
(cherry picked from commit 2a00e2b)
vinayak15 pushed a commit to vinayak15/security that referenced this pull request Sep 29, 2022
stephen-crawford added a commit to stephen-crawford/security that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JNA dependency description in THIRD-PARTY.txt
4 participants