[Backport 2.x] Correct Java Native Access Description in THIRD-PARTY.txt #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: Stephen Crawford <steecraw@amazon.com> (cherry picked from commit 2a00e2b)
Codecov Report
@@ Coverage Diff @@
## 2.x #2111 +/- ##
=========================================
Coverage 61.03% 61.03%
Complexity 3228 3228
=========================================
Files 256 256
Lines 18080 18080
Branches 3225 3225
=========================================
Hits 11036 11036
Misses 5467 5467
Partials 1577 1577 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternied
requested changes
Sep 27, 2022
There was a problem hiding this comment.
This boils down to a documentation change which is only really valid from our main branch, I don't think we should backport this change. I think we should close this pull request without merging, how does this occur to you @cwperks?
|
@peternied As a rule of thumb, I have been backporting any change to unreleased 2.x unless it is a breaking change that cannot be released on the 2.x line. |
|
Spoke offline with @cwperks, closing this out since it isn't need in backport versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2a00e2b from #2107