Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Andriy Redko as a co-maintainer #2610

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

peternied
Copy link
Member

@peternied peternied commented Mar 30, 2023

Description

I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our nomination process. The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

  • Code
    • Features work such as support for HTTP/2
    • Manual Backports for CVEs
    • Build infrastructure such as Gradle changes
    • Test infrastructure such as fixes to OpenSSLTests
  • Particpation in issues
  • Adding contributors
  • Active participate in triage meeting / process
  • Passion for quality

Thank you

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our [nomination process](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#nomination). The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

* Code
  * Features work such as support for HTTP/2
  * Manual Backports for CVEs
  * Build infrastructure such as Gradle changes
  * Test infrastructure such as fixes to OpenSSLTests
* Particpation in issues
* Adding contributors
  * @willyborankin
* Active participate in triage meeting / process
* Passion for quality

Thank you

Signed-off-by: Peter Nied <petern@amazon.com>
Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't agree more, @reta has made many valuable contributions to this repo and many other repos across the OpenSearch ecosystem.

@willyborankin
Copy link
Collaborator

willyborankin commented Mar 30, 2023

I think

Adding contributors
    @willyborankin

should be:
```@reta```` :-)

@@ -1 +1 @@
* @cliu123 @cwperks @DarshitChanpura @davidlago @peternied @RyanL1997 @scrawfor99
* @cliu123 @cwperks @DarshitChanpura @davidlago @peternied @RyanL1997 @scrawfor99 @reta
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwperks Can you wait for changes on this PR until this warning goes away? Unknown owner on line 1: make sure @reta exists and has write access to the repository

I am waiting for our project admins to make the updates to the settings.

@codecov-commenter
Copy link

Codecov Report

Merging #2610 (f826d9d) into main (30c967e) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #2610   +/-   ##
=========================================
  Coverage     61.25%   61.25%           
  Complexity     3330     3330           
=========================================
  Files           260      260           
  Lines         18509    18509           
  Branches       3269     3269           
=========================================
+ Hits          11337    11338    +1     
  Misses         5576     5576           
+ Partials       1596     1595    -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard @reta !

Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard Andriy!

@RyanL1997
Copy link
Collaborator

Welcome to the club @reta!

@stephen-crawford stephen-crawford merged commit d476687 into opensearch-project:main Mar 31, 2023
RyanL1997 pushed a commit to RyanL1997/security that referenced this pull request Apr 4, 2023
I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our [nomination process](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#nomination). The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

* Code
  * Features work such as support for HTTP/2
  * Manual Backports for CVEs
  * Build infrastructure such as Gradle changes
  * Test infrastructure such as fixes to OpenSSLTests
* Particpation in issues
* Adding contributors
  * @willyborankin
* Active participate in triage meeting / process
* Passion for quality

Thank you

Signed-off-by: Peter Nied <petern@amazon.com>
stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request Apr 6, 2023
I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our [nomination process](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#nomination). The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

* Code
  * Features work such as support for HTTP/2
  * Manual Backports for CVEs
  * Build infrastructure such as Gradle changes
  * Test infrastructure such as fixes to OpenSSLTests
* Particpation in issues
* Adding contributors
  * @willyborankin
* Active participate in triage meeting / process
* Passion for quality

Thank you

Signed-off-by: Peter Nied <petern@amazon.com>
@davidlago
Copy link

Late to the welcome party... but, welcome to the team, @reta!

@peternied peternied deleted the new-maintainer branch April 7, 2023 21:22
stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request Apr 11, 2023
I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our [nomination process](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#nomination). The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

* Code
  * Features work such as support for HTTP/2
  * Manual Backports for CVEs
  * Build infrastructure such as Gradle changes
  * Test infrastructure such as fixes to OpenSSLTests
* Particpation in issues
* Adding contributors
  * @willyborankin
* Active participate in triage meeting / process
* Passion for quality

Thank you

Signed-off-by: Peter Nied <petern@amazon.com>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Apr 11, 2023
I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our [nomination process](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#nomination). The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

* Code
  * Features work such as support for HTTP/2
  * Manual Backports for CVEs
  * Build infrastructure such as Gradle changes
  * Test infrastructure such as fixes to OpenSSLTests
* Particpation in issues
* Adding contributors
  * @willyborankin
* Active participate in triage meeting / process
* Passion for quality

Thank you

Signed-off-by: Peter Nied <petern@amazon.com>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Apr 20, 2023
I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our [nomination process](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#nomination). The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

* Code
  * Features work such as support for HTTP/2
  * Manual Backports for CVEs
  * Build infrastructure such as Gradle changes
  * Test infrastructure such as fixes to OpenSSLTests
* Particpation in issues
* Adding contributors
  * @willyborankin
* Active participate in triage meeting / process
* Passion for quality

Thank you

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Apr 27, 2023
I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our [nomination process](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#nomination). The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

* Code
  * Features work such as support for HTTP/2
  * Manual Backports for CVEs
  * Build infrastructure such as Gradle changes
  * Test infrastructure such as fixes to OpenSSLTests
* Particpation in issues
* Adding contributors
  * @willyborankin
* Active participate in triage meeting / process
* Passion for quality

Thank you

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Jun 13, 2023
I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our [nomination process](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#nomination). The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

* Code
  * Features work such as support for HTTP/2
  * Manual Backports for CVEs
  * Build infrastructure such as Gradle changes
  * Test infrastructure such as fixes to OpenSSLTests
* Particpation in issues
* Adding contributors
  * @willyborankin
* Active participate in triage meeting / process
* Passion for quality

Thank you

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Jun 13, 2023
I nominated Andriy Redko (@reta) to be a co-maintainer for Security through our [nomination process](https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#nomination). The maintainers have agreed, and Andriy has kindly accepted.

Andriy’s involvement has taken many shapes, here are some highlights:

* Code
  * Features work such as support for HTTP/2
  * Manual Backports for CVEs
  * Build infrastructure such as Gradle changes
  * Test infrastructure such as fixes to OpenSSLTests
* Particpation in issues
* Adding contributors
  * @willyborankin
* Active participate in triage meeting / process
* Passion for quality

Thank you

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
@peternied peternied added backport 1.x backport to 1.x branch backport 1.3 backport to 1.3 branch backport 2.x backport to 2.x branch labels Jun 13, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2610-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d47668756fda437dffb24a53f9b38f6579812d62
# Push it to GitHub
git push --set-upstream origin backport/backport-2610-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2610-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2610-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d47668756fda437dffb24a53f9b38f6579812d62
# Push it to GitHub
git push --set-upstream origin backport/backport-2610-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2610-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2610-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d47668756fda437dffb24a53f9b38f6579812d62
# Push it to GitHub
git push --set-upstream origin backport/backport-2610-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2610-to-1.x.

@peternied peternied removed backport 1.x backport to 1.x branch backport 1.3 backport to 1.3 branch backport 2.x backport to 2.x branch labels Jun 13, 2023
@peternied
Copy link
Member Author

FYI - Manually backport associated with #2843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants