Add conversation indices to install_demo_configuration.sh #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System indices for conversation memory feature going into ml-commons Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
HenryL27
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
dhrubo-os
approved these changes
Sep 7, 2023
ylwu-amzn
approved these changes
Sep 7, 2023
|
@HenryL27 Can you also make the same change to the batch script? https://github.com/opensearch-project/security/blob/main/tools/install_demo_configuration.bat |
|
Tried to switch the PR to be against main, didn't take - please rebase this change and change the target of this pull request, or create a fresh pull request against main. |
|
new PR created to the right place and correct files #3326 . will close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System indices for conversation memory feature going into ml-commons
Description
Add conversation memory system indices as system indices
Issues Resolved
ml-commons 1150
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.