-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add conversation system indices for conversation memory experimental … #3326
Merged
cwperks
merged 1 commit into
opensearch-project:main
from
HenryL27:add-conversation-system-indices
Sep 7, 2023
Merged
add conversation system indices for conversation memory experimental … #3326
cwperks
merged 1 commit into
opensearch-project:main
from
HenryL27:add-conversation-system-indices
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
HenryL27
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
September 7, 2023 15:24
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #3326 +/- ##
============================================
+ Coverage 63.24% 64.19% +0.94%
- Complexity 3452 3471 +19
============================================
Files 263 263
Lines 20053 20112 +59
Branches 3348 3359 +11
============================================
+ Hits 12683 12910 +227
+ Misses 5741 5528 -213
- Partials 1629 1674 +45 |
cwperks
approved these changes
Sep 7, 2023
dhrubo-os
approved these changes
Sep 7, 2023
willyborankin
approved these changes
Sep 7, 2023
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3326-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 72c61865b4c318a64ad0c14041797a7f4d2d46fd
# Push it to GitHub
git push --set-upstream origin backport/backport-3326-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
Opening up a manual backport |
peternied
pushed a commit
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…feature
Description
add the conversation memory experimental feature system indices as system indices
Issues Resolved
ml-commons 1150
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.