-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to 1.0.0 (prepare for release) #75
Conversation
@dblock please take a look when you have time |
@dblock please take a look when you have time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbarani Do we need to do anything else here related to security reviews?
Sorry this somehow was below my GitHub email/notifications bar ;( |
@wbeckler @dlvenable please let us know if this needs to wait until security reviews are completed. |
Just wondering: any progress on security reviews? |
Any thoughts approximately when the release will be done? Thanks |
@dblock could you please help with security reviews, not sure what it entails? |
Security reviews are successfully completed and this can be approved. |
@dblock would you be willing to approve? |
@gaiksaya could you please enable the release job on Jenkins? https://build.ci.opensearch.org/job/spring-data-opensearch-release/, thank you |
Done! |
@gaiksaya I pushed the pre-release 0.2.0 [1] but Jenkins job didn't trigger [2], mind please taking a look? [1] https://github.com/opensearch-project/spring-data-opensearch/releases/tag/0.2.0 |
@reta, The workflow is based on draft release as a trigger which is generated using release-drafter.yml . I see it is marked as pre-release. You should just push the tag and let it do its thing. Once release is published, you can make is pre-release. |
@gaiksaya redid the tag [1] + release [2] - nothing is happening [1] https://github.com/opensearch-project/spring-data-opensearch/tags |
Taking a look! |
@reta Can you confirm that 0.2.0 tag is based on main? I'll try triggering it from my end |
Its running: https://build.ci.opensearch.org/job/spring-data-opensearch-release/9/. |
I can see it: https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/client/spring-data-opensearch-starter/0.2.0/ Thanks! |
Oh I see now, so it does not work when (pre)release is created using Github, understood, thank you! |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
What's the next step to get this released as a 1.0? |
@wbeckler just an approval from one of the maintainers (@dblock , @dlvenable ), I cannot merge the pull request otherwise |
@dblock can you take a look? Appsec review is a done. |
@dlvenable are you okay to approve? The appsec review is complete. |
Done! Sorry for the delay. |
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
Update version to 1.0.0 (prepare for release)
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.