Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 1.0.0 (prepare for release) #75

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Dec 15, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Update version to 1.0.0 (prepare for release)

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator Author

reta commented Dec 20, 2022

@dblock please take a look when you have time

@reta
Copy link
Collaborator Author

reta commented Dec 30, 2022

@dblock please take a look when you have time

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbarani Do we need to do anything else here related to security reviews?

@dblock
Copy link
Member

dblock commented Jan 9, 2023

@dblock please take a look when you have time

Sorry this somehow was below my GitHub email/notifications bar ;(

@bbarani
Copy link
Member

bbarani commented Jan 9, 2023

@wbeckler @dlvenable please let us know if this needs to wait until security reviews are completed.

@exZStas
Copy link

exZStas commented Jan 19, 2023

Just wondering: any progress on security reviews?

@nsanaia
Copy link

nsanaia commented Jan 23, 2023

Any thoughts approximately when the release will be done? Thanks

@reta
Copy link
Collaborator Author

reta commented Jan 24, 2023

@dblock could you please help with security reviews, not sure what it entails?

@wbeckler
Copy link

Security reviews are successfully completed and this can be approved.

@wbeckler
Copy link

@dblock would you be willing to approve?

@reta
Copy link
Collaborator Author

reta commented Jan 26, 2023

@gaiksaya could you please enable the release job on Jenkins? https://build.ci.opensearch.org/job/spring-data-opensearch-release/, thank you

@gaiksaya
Copy link
Member

@gaiksaya could you please enable the release job on Jenkins? https://build.ci.opensearch.org/job/spring-data-opensearch-release/, thank you

Done!
cc: @bbarani

@reta
Copy link
Collaborator Author

reta commented Jan 26, 2023

@gaiksaya could you please enable the release job on Jenkins? https://build.ci.opensearch.org/job/spring-data-opensearch-release/, thank you

@gaiksaya I pushed the pre-release 0.2.0 [1] but Jenkins job didn't trigger [2], mind please taking a look?

[1] https://github.com/opensearch-project/spring-data-opensearch/releases/tag/0.2.0
[2] https://build.ci.opensearch.org/job/spring-data-opensearch-release/

@gaiksaya
Copy link
Member

@reta, The workflow is based on draft release as a trigger which is generated using release-drafter.yml . I see it is marked as pre-release. You should just push the tag and let it do its thing. Once release is published, you can make is pre-release.

@reta
Copy link
Collaborator Author

reta commented Jan 26, 2023

@reta, The workflow is based on draft release as a trigger which is generated using release-drafter.yml . I see it is marked as pre-release. You should just push the tag and let it do its thing. Once release is published, you can make is pre-release.

@gaiksaya redid the tag [1] + release [2] - nothing is happening

[1] https://github.com/opensearch-project/spring-data-opensearch/tags
[2] https://github.com/opensearch-project/spring-data-opensearch/releases/tag/0.2.0

@gaiksaya
Copy link
Member

Taking a look!

@gaiksaya
Copy link
Member

@reta Can you confirm that 0.2.0 tag is based on main? I'll try triggering it from my end
Thanks!

@reta
Copy link
Collaborator Author

reta commented Jan 26, 2023

@reta Can you confirm that 0.2.0 tag is based on main? I'll try triggering it from my end Thanks!

@gaiksaya yes, it does, latest commit to main

@gaiksaya
Copy link
Member

gaiksaya commented Jan 26, 2023

Its running: https://build.ci.opensearch.org/job/spring-data-opensearch-release/9/.
I did not push the tag just deleted the GH release and re-ran the release-drafter workflow. Once the release is successful, the release is auto-published on release. I believe, before it can trigger the workflow the release was published by you :D
The idea is GH release should be published on GH only when the components are out there In this case on maven.

@gaiksaya
Copy link
Member

I can see it: https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/client/spring-data-opensearch-starter/0.2.0/
Feel free to edit the GH release as you want now.

Thanks!

@reta
Copy link
Collaborator Author

reta commented Jan 26, 2023

Its running: https://build.ci.opensearch.org/job/spring-data-opensearch-release/9/. I did not push the tag just deleted the GH release and re-ran the release-drafter workflow. Once the release is successful, the release is auto-published on release. I believe, before it can trigger the workflow the release was published by you :D The idea is GH release should be published on GH only when the components are out there In this case on maven.

Oh I see now, so it does not work when (pre)release is created using Github, understood, thank you!

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta requested a review from dblock January 26, 2023 21:02
@wbeckler
Copy link

What's the next step to get this released as a 1.0?

@reta
Copy link
Collaborator Author

reta commented Jan 27, 2023

What's the next step to get this released as a 1.0?

@wbeckler just an approval from one of the maintainers (@dblock , @dlvenable ), I cannot merge the pull request otherwise

@wbeckler
Copy link

@dblock can you take a look? Appsec review is a done.

@wbeckler
Copy link

wbeckler commented Feb 1, 2023

@dlvenable are you okay to approve? The appsec review is complete.

@dblock dblock merged commit 45770cf into opensearch-project:main Feb 1, 2023
@dblock
Copy link
Member

dblock commented Feb 1, 2023

Done! Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants