Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline repo groups #1384

Merged
merged 5 commits into from
Mar 21, 2023
Merged

baseline repo groups #1384

merged 5 commits into from
Mar 21, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Feb 28, 2023

Description

[Describe what this change achieves]

Issues Resolved

Fix #1337

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho marked this pull request as ready for review February 28, 2023 16:31
@derek-ho derek-ho requested a review from a team as a code owner February 28, 2023 16:31
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #1384 (b147bcd) into main (b826835) will decrease coverage by 1.51%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #1384      +/-   ##
============================================
- Coverage     99.96%   98.46%   -1.51%     
- Complexity     2464     3846    +1382     
============================================
  Files           220      345     +125     
  Lines          5833     9553    +3720     
  Branches        359      613     +254     
============================================
+ Hits           5831     9406    +3575     
- Misses            2      142     +140     
- Partials          0        5       +5     
Flag Coverage Δ
sql-engine 98.46% <ø> (-1.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 139 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yury-Fridlyand
Copy link
Collaborator

According to opensearch-project/.github#125:

  1. Add active maintainers to CODEOWNERS.

The proposed CODEOWNERS list has much more people than listed in MAINTAINERS.md. I think repo/organization admins like Charlotte (CEHENKLE) can do whatever they need with the repository without being listed in CODEOWNERS. This just subscribes them to spam aka PR open/close.

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: Derek Ho <dxho@amazon.com>
rupal-bq
rupal-bq previously approved these changes Mar 15, 2023
dai-chen
dai-chen previously approved these changes Mar 21, 2023
Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho dismissed stale reviews from dai-chen and rupal-bq via b147bcd March 21, 2023 21:01
@derek-ho derek-ho merged commit aa92f99 into opensearch-project:main Mar 21, 2023
@rupal-bq rupal-bq mentioned this pull request Mar 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions
7 participants