Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport codeowners changes to 2.x #1566

Merged
merged 3 commits into from
May 11, 2023

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Apr 20, 2023

Description

Backport #1384, #1466 #1579 to 2.x.

Issues Resolved

#1337

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner April 20, 2023 19:00
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #1566 (1f704a0) into 2.x (dfdbc57) will decrease coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #1566      +/-   ##
============================================
- Coverage     97.18%   97.16%   -0.03%     
- Complexity     4104     4118      +14     
============================================
  Files           371      371              
  Lines         10459    10368      -91     
  Branches        706      704       -2     
============================================
- Hits          10165    10074      -91     
  Misses          287      287              
  Partials          7        7              
Flag Coverage Δ
sql-engine 97.16% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

penghuo
penghuo previously approved these changes Apr 24, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 562cbfa into opensearch-project:2.x May 11, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the backport-codeowners branch May 11, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants