Keep up with refactors in core -- Strings class #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKsyunz
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
Yury-Fridlyand,
anirudha,
forestmvey and
acarbonetto
as code owners
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
MaxKsyunz
force-pushed
the
chore/strings-in-core
branch
from
4acb545 to
b5c900b
Compare
|
SQL Java CI is failing currently because snapshot builds have not caught up. |
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
=========================================
Coverage 97.16% 97.16%
Complexity 4120 4120
=========================================
Files 371 371
Lines 10373 10373
Branches 704 704
=========================================
Hits 10079 10079
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
MitchellGale
approved these changes
May 23, 2023
Yury-Fridlyand
approved these changes
May 23, 2023
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
May 24, 2023
…roject#1645) Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
MaxKsyunz
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
May 25, 2023
…roject#1645) Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> (cherry picked from commit 8e5d766)
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…roject#1645) Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…roject#1645) Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> (cherry picked from commit 8e5d766)
MaxKsyunz
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 7, 2023
…roject#1645) Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> (cherry picked from commit 8e5d766) Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
MaxKsyunz
added a commit
that referenced
this pull request
Jul 7, 2023
* Updating imports to reflect changes in opensearch core. (#1645) Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> (cherry picked from commit 8e5d766) Signed-off-by: Max Ksyunz <max.ksyunz@improving.com> * Forcing httpclient to 4.5.14 Signed-off-by: Max Ksyunz <max.ksyunz@improving.com> --------- Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: Max Ksyunz <max.ksyunz@improving.com> Co-authored-by: Max Ksyunz <maxk@bitquilltech.com> Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sql plugin to account for changes in opensearch-project/OpenSearch#7508