Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Keep up with refactors in core -- Strings class #1812

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8e5d766 from #1645

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
(cherry picked from commit 8e5d766)
Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1812 (242b306) into 2.x (babbe90) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #1812   +/-   ##
=========================================
  Coverage     97.35%   97.35%           
  Complexity     4443     4443           
=========================================
  Files           388      388           
  Lines         10997    10997           
  Branches        784      784           
=========================================
  Hits          10706    10706           
  Misses          284      284           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MaxKsyunz MaxKsyunz force-pushed the backport/backport-1645-to-2.x branch from 2b0ae67 to 137abd6 Compare July 7, 2023 00:26
Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
@MaxKsyunz MaxKsyunz force-pushed the backport/backport-1645-to-2.x branch from 6a8f4fe to 242b306 Compare July 7, 2023 19:06
@MaxKsyunz
Copy link
Collaborator

SQL Java CI failures are in doctest due to another PR not being backported.

It will be resolved separately with #1818.

Failed example:
    pretty_print(sh("""curl -sS -H 'Content-Type: application/json' \
    -X POST localhost:9200/_plugins/_ppl \
    -d '{"query" : "source=unknown | fields firstname, lastname"}'
    """).stdout.decode("utf-8"))
Expected:
    {
      "error": {
        "reason": "Error occurred in OpenSearch engine: no such index [unknown]",
        "details": "org.opensearch.index.IndexNotFoundException: no such index [unknown]\nFor more details, please send request for Json format to see the raw response from OpenSearch engine.",
        "type": "IndexNotFoundException"
      },
      "status": 404
    }
Got:
    {
      "error": {
        "reason": "Error occurred in OpenSearch engine: no such index [unknown]",
        "details": "[unknown] IndexNotFoundException[no such index [unknown]]\nFor more details, please send request for Json format to see the raw response from OpenSearch engine.",
        "type": "IndexNotFoundException"
      },
      "status": 404
    }

@MaxKsyunz MaxKsyunz merged commit fa82bae into 2.x Jul 7, 2023
@github-actions github-actions bot deleted the backport/backport-1645-to-2.x branch July 7, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants