-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change OpenSearch main project - Action movement #1958
Breaking change OpenSearch main project - Action movement #1958
Conversation
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
...h/src/main/java/org/opensearch/sql/opensearch/planner/physical/MLCommonsOperatorActions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Codecov Report
@@ Coverage Diff @@
## main #1958 +/- ##
=========================================
Coverage 97.51% 97.51%
Complexity 4657 4657
=========================================
Files 408 408
Lines 11930 11933 +3
Branches 830 829 -1
=========================================
+ Hits 11633 11637 +4
+ Misses 290 289 -1
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Why CI fails? |
…earchDataSourceMetadataStorageTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
…CheckScriptContents QueryPlannerTest.java SparkResponseTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixed now - was missing a few updates. |
…-project#1958) * fixing breaking change before ML fix. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * More fixes for core breaking change. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Remove d L at end of actionGet int Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding missed import updates for ElasticDefaultRestExecutor and OpenSearchDataSourceMetadataStorageTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding missed import updates for SparkResponse.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding missed import updates for BindingTupleQueryPlannerExecuteTest CheckScriptContents QueryPlannerTest.java SparkResponseTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-1958-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 245c4f86bbc5b301051f0dcfc239458752267786
# Push it to GitHub
git push --set-upstream origin backport/backport-1958-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
…-project#1958) * fixing breaking change before ML fix. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * More fixes for core breaking change. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Remove d L at end of actionGet int Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding missed import updates for ElasticDefaultRestExecutor and OpenSearchDataSourceMetadataStorageTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding missed import updates for SparkResponse.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Adding missed import updates for BindingTupleQueryPlannerExecuteTest CheckScriptContents QueryPlannerTest.java SparkResponseTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-1958-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 245c4f86bbc5b301051f0dcfc239458752267786
# Push it to GitHub
git push --set-upstream origin backport/backport-1958-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
) * fixing breaking change before ML fix. * More fixes for core breaking change. * spotless apply. * Remove d L at end of actionGet int * Adding missed import updates for ElasticDefaultRestExecutor and OpenSearchDataSourceMetadataStorageTest.java * Adding missed import updates for SparkResponse.java * Adding missed import updates for BindingTupleQueryPlannerExecuteTest CheckScriptContents QueryPlannerTest.java SparkResponseTest.java --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Description
Breaking change by OpenSearch. New location for some functions, so libraries updated respectively.
opensearch-project/OpenSearch#9082
Issues Resolved
#1953
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.