Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Breaking change OpenSearch main project - Action movement (#1958) #1965

Merged

Conversation

MitchellGale
Copy link
Contributor

@MitchellGale MitchellGale commented Aug 15, 2023

Description

Breaking change by OpenSearch. New location for some functions, so libraries updated respectively.
opensearch-project/OpenSearch#9082

Depends on: opensearch-project/ml-commons#1206

Issues Resolved

#1953

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…-project#1958)

* fixing breaking change before ML fix.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* More fixes for core breaking change.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* spotless apply.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Remove d L at end of actionGet int

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Adding missed import updates for ElasticDefaultRestExecutor and OpenSearchDataSourceMetadataStorageTest.java

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Adding missed import updates for SparkResponse.java

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Adding missed import updates for BindingTupleQueryPlannerExecuteTest CheckScriptContents QueryPlannerTest.java SparkResponseTest.java

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1965 (d335457) into 2.x (76f6de9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #1965   +/-   ##
=========================================
  Coverage     97.42%   97.42%           
  Complexity     4647     4647           
=========================================
  Files           408      408           
  Lines         11528    11528           
  Branches        837      837           
=========================================
  Hits          11231    11231           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...odel/transport/CreateDataSourceActionResponse.java 0.00% <ø> (ø)
...odel/transport/DeleteDataSourceActionResponse.java 0.00% <ø> (ø)
...s/model/transport/GetDataSourceActionResponse.java 0.00% <ø> (ø)
...odel/transport/UpdateDataSourceActionResponse.java 0.00% <ø> (ø)
...ql/datasources/rest/RestDataSourceQueryAction.java 0.00% <ø> (ø)
...s/storage/OpenSearchDataSourceMetadataStorage.java 98.74% <ø> (ø)
...ces/transport/TransportCreateDataSourceAction.java 100.00% <ø> (ø)
...ces/transport/TransportDeleteDataSourceAction.java 100.00% <ø> (ø)
...ources/transport/TransportGetDataSourceAction.java 100.00% <ø> (ø)
...ces/transport/TransportUpdateDataSourceAction.java 100.00% <ø> (ø)
... and 1 more

@MitchellGale MitchellGale marked this pull request as draft August 15, 2023 21:31
@MitchellGale MitchellGale marked this pull request as ready for review August 15, 2023 22:31
@Yury-Fridlyand Yury-Fridlyand merged commit 1b5a936 into opensearch-project:2.x Aug 15, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the backport/backport-1958-to-2.x branch August 15, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants