Add option to swap arguments in lucene queries #2002
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lucene queries accept field reference (column/field name) at the first arg only (on the left side). If reference is on the right - query fails or performed with significant overhead.
Example 1
(query succeeded)
(query failed)
Example 2
Query 1
Explain
Query 2
Explain
With proposed changes
explain
for both queries in the second example will be same. Query in the first example would work properly.Notes
This is a PoC. WIP.
With a properly wrapped lucene query we can avoid storing (and using)
castMap
inLuceneQuery
, which completely duplicatesTypeCastOperator
.This should be done before or together with moving OpenSearch functions out of
:core
. Ref: UDF (User Defined Functions), #811.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.