PoC Refactor: Move relevance search functions from :core
to :opensearch
#2025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Phase 2 of UDF (User Defined Function) implementation
(See phase 1 in #2019)
Depends on #2001 (a rough fix for that is included in this PR, but it should be merged in scope of another PR in advance.
Fix proposed in #2002 could be done prior to these changes to simplify the refactor.
These changes include:
:core
to:opensearch
StorageEngine
provides API to get DS-specific analyzers, which is used by analyzer in:core
(common to all DS)TODOs:
Analyzer
s andCanPaginateVisitor
abstract, every DS should provide their own implementationNext Steps (phases):
SQL engine should try to execute a query on all
StorageEngine
s (Data Sources), using only oneStorageEngine
from the very beginning to the very end (QueryPlanFactory
-ExecutionEngine::execute
) and pick one which succeeds to build a Physical Plan tree.TBD: what if multiple
StorageEngine
s can build a tree?Note: reuse common parts for better performance.
important: this could be moved to the next phase if current one would be implemented with not more that one DS.
Issues Resolved
P2 of #811
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.