-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applied formatting improvements to Antlr files based on spotless changes #2017
Merged
GumpacG
merged 2 commits into
opensearch-project:main
from
Bit-Quill:integ-antlr-spotless
Aug 22, 2023
Merged
Applied formatting improvements to Antlr files based on spotless changes #2017
GumpacG
merged 2 commits into
opensearch-project:main
from
Bit-Quill:integ-antlr-spotless
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges (#342) Signed-off-by: Matthew Wells <matthew.wells@improving.com>
matthewryanwells
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
August 22, 2023 22:23
MitchellGale
approved these changes
Aug 22, 2023
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
acarbonetto
approved these changes
Aug 22, 2023
MitchellGale
approved these changes
Aug 22, 2023
GumpacG
approved these changes
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #2017 +/- ##
=========================================
Coverage 97.30% 97.30%
Complexity 4623 4623
=========================================
Files 407 407
Lines 11935 11935
Branches 828 828
=========================================
Hits 11613 11613
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2017-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed2b683064ee2adb2d449d0cbba565cd54137e3a
# Push it to GitHub
git push --set-upstream origin backport/backport-2017-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 23, 2023
…ges (opensearch-project#2017) * Applied formatting improvements to Antlr files based on spotless changes (#342) Signed-off-by: Matthew Wells <matthew.wells@improving.com> * added spacing to # names back into parser files Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Aug 23, 2023
…n spotless changes (#2017) (#2023) * Applied formatting improvements to Antlr files based on spotless changes (#2017) * Applied formatting improvements to Antlr files based on spotless changes (#342) Signed-off-by: Matthew Wells <matthew.wells@improving.com> * added spacing to # names back into parser files Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> * Update sql/src/main/antlr/OpenSearchSQLParser.g4 Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * fixed extra semi colon Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed formatting of Antlr
parser
files based on Spotless changes. I have not applied the changes made to thelexer
files as it completely rewrites the files to make them much less readableIssues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.