-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Applied formatting improvements to Antlr files based on spotless changes (#2017) #2023
Merged
Yury-Fridlyand
merged 3 commits into
opensearch-project:2.x
from
Bit-Quill:backport2.x-2017
Aug 23, 2023
Merged
[Backport 2.x] Applied formatting improvements to Antlr files based on spotless changes (#2017) #2023
Yury-Fridlyand
merged 3 commits into
opensearch-project:2.x
from
Bit-Quill:backport2.x-2017
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
August 23, 2023 00:22
MitchellGale
force-pushed
the
backport2.x-2017
branch
from
August 23, 2023 00:24
b5b937a
to
c6b37d0
Compare
…ges (opensearch-project#2017) * Applied formatting improvements to Antlr files based on spotless changes (#342) Signed-off-by: Matthew Wells <matthew.wells@improving.com> * added spacing to # names back into parser files Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #2023 +/- ##
=========================================
Coverage 97.33% 97.33%
Complexity 4659 4659
=========================================
Files 408 408
Lines 12100 12101 +1
Branches 830 830
=========================================
+ Hits 11778 11779 +1
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
acarbonetto
previously approved these changes
Aug 23, 2023
Yury-Fridlyand
previously approved these changes
Aug 23, 2023
MitchellGale
commented
Aug 23, 2023
MitchellGale
dismissed stale reviews from Yury-Fridlyand and acarbonetto
via
August 23, 2023 00:41
f3ee74b
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
acarbonetto
approved these changes
Aug 23, 2023
Yury-Fridlyand
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed formatting of Antlr parser files based on Spotless changes. I have not applied the changes made to the lexer files as it completely rewrites the files to make them much less readable
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.