Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Applied formatting improvements to Antlr files based on spotless changes (#2017) #2023

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

MitchellGale
Copy link
Contributor

@MitchellGale MitchellGale commented Aug 23, 2023

Description

Changed formatting of Antlr parser files based on Spotless changes. I have not applied the changes made to the lexer files as it completely rewrites the files to make them much less readable

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ges (opensearch-project#2017)

* Applied formatting improvements to Antlr files based on spotless changes (#342)

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* added spacing to # names back into parser files

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

---------

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@MitchellGale MitchellGale reopened this Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2023 (ff90815) into 2.x (c6b37d0) will increase coverage by 0.00%.
Report is 3 commits behind head on 2.x.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #2023   +/-   ##
=========================================
  Coverage     97.33%   97.33%           
  Complexity     4659     4659           
=========================================
  Files           408      408           
  Lines         12100    12101    +1     
  Branches        830      830           
=========================================
+ Hits          11778    11779    +1     
  Misses          315      315           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

acarbonetto
acarbonetto previously approved these changes Aug 23, 2023
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 23, 2023
MitchellGale and others added 2 commits August 22, 2023 17:41
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 3c8e3bd into opensearch-project:2.x Aug 23, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the backport2.x-2017 branch August 23, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants