Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of new job APIs #2050

Merged

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Sep 6, 2023

Description

  • Contains Rest, Transport Layer Files for new job APIs.
  • Currently we are making the changes in spark connector module, we may move to a new module once the design becomes concrete.
  • Documentation will be added in individual API PRs.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vmmusings vmmusings changed the base branch from main to feature/job-apis September 6, 2023 01:13
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2050 (d82996f) into feature/job-apis (e5fa313) will decrease coverage by 0.92%.
Report is 1 commits behind head on feature/job-apis.
The diff coverage is 21.37%.

@@                  Coverage Diff                   @@
##             feature/job-apis    #2050      +/-   ##
======================================================
- Coverage               97.27%   96.36%   -0.92%     
- Complexity               4623     4639      +16     
======================================================
  Files                     410      424      +14     
  Lines                   11947    12092     +145     
  Branches                  828      832       +4     
======================================================
+ Hits                    11621    11652      +31     
- Misses                    317      431     +114     
  Partials                    9        9              
Flag Coverage Δ
sql-engine 96.36% <21.37%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...search/sql/spark/rest/RestJobManagementAction.java 0.00% <0.00%> (ø)
...nsearch/sql/spark/rest/model/CreateJobRequest.java 0.00% <0.00%> (ø)
...spark/transport/model/CreateJobActionResponse.java 0.00% <0.00%> (ø)
.../spark/transport/model/DeleteJobActionRequest.java 0.00% <0.00%> (ø)
...spark/transport/model/DeleteJobActionResponse.java 0.00% <0.00%> (ø)
...sql/spark/transport/model/GetJobActionRequest.java 0.00% <0.00%> (ø)
...ql/spark/transport/model/GetJobActionResponse.java 0.00% <0.00%> (ø)
...ransport/model/GetJobQueryResultActionRequest.java 0.00% <0.00%> (ø)
...ansport/model/GetJobQueryResultActionResponse.java 0.00% <0.00%> (ø)
.../spark/transport/model/CreateJobActionRequest.java 50.00% <50.00%> (ø)
... and 4 more

@vmmusings vmmusings force-pushed the feature/job-apis branch 5 times, most recently from c7a19fc to 3ae20f8 Compare September 8, 2023 03:17
@vmmusings vmmusings self-assigned this Sep 8, 2023
@vmmusings vmmusings added the enhancement New feature or request label Sep 8, 2023
@vmmusings vmmusings marked this pull request as ready for review September 8, 2023 03:33
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
@vmmusings vmmusings merged commit a7af359 into opensearch-project:feature/job-apis Sep 9, 2023
11 of 19 checks passed
vmmusings added a commit that referenced this pull request Sep 22, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vmmusings added a commit that referenced this pull request Sep 22, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vmmusings added a commit that referenced this pull request Sep 27, 2023
* Glue datasource support (#2055)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Initial commit of new job APIs (#2050)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Create Job API (#2070)

* Create Job API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Cancel Job API (#2126)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Add tags to the emr jobs based on the query types (#2150)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 27, 2023
* Glue datasource support (#2055)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Initial commit of new job APIs (#2050)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Create Job API (#2070)

* Create Job API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Cancel Job API (#2126)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Add tags to the emr jobs based on the query types (#2150)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit ae10857)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings pushed a commit that referenced this pull request Sep 27, 2023
* Glue datasource support (#2055)



* Initial commit of new job APIs (#2050)



* Create Job API (#2070)

* Create Job API



* Refactor to Async Query API



---------



* Cancel Job API (#2126)



* Add tags to the emr jobs based on the query types (#2150)



---------


(cherry picked from commit ae10857)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Oct 3, 2023
* Glue datasource support (#2055)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Initial commit of new job APIs (#2050)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Create Job API (#2070)

* Create Job API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Cancel Job API (#2126)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Fix response codes returned

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove @opensearch datasource, update with new type

Signed-off-by: Derek Ho <dxho@amazon.com>

* Spotless Apply

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix tests

Signed-off-by: Derek Ho <dxho@amazon.com>

* Revert change back to json string

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update tests to use JSON string literal instead of formatting

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update IT

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix show datsources IT

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove files from merge

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2023
* Glue datasource support (#2055)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Initial commit of new job APIs (#2050)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Create Job API (#2070)

* Create Job API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Cancel Job API (#2126)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Fix response codes returned

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove @opensearch datasource, update with new type

Signed-off-by: Derek Ho <dxho@amazon.com>

* Spotless Apply

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix tests

Signed-off-by: Derek Ho <dxho@amazon.com>

* Revert change back to json string

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update tests to use JSON string literal instead of formatting

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update IT

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix show datsources IT

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove files from merge

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit 5ce1bab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Oct 3, 2023
* Glue datasource support (#2055)



* Initial commit of new job APIs (#2050)



* Create Job API (#2070)

* Create Job API



* Refactor to Async Query API



---------



* Cancel Job API (#2126)



* Fix response codes returned



* Remove @opensearch datasource, update with new type



* Spotless Apply



* Fix tests



* Revert change back to json string



* Update tests to use JSON string literal instead of formatting



* Update IT



* Fix show datsources IT



* Remove files from merge



---------




(cherry picked from commit 5ce1bab)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants