[Backport 2.x] Fix response codes returned by JSON formatting them #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Fix response codes returned Signed-off-by: Derek Ho <dxho@amazon.com> * Remove @opensearch datasource, update with new type Signed-off-by: Derek Ho <dxho@amazon.com> * Spotless Apply Signed-off-by: Derek Ho <dxho@amazon.com> * Fix tests Signed-off-by: Derek Ho <dxho@amazon.com> * Revert change back to json string Signed-off-by: Derek Ho <dxho@amazon.com> * Update tests to use JSON string literal instead of formatting Signed-off-by: Derek Ho <dxho@amazon.com> * Update IT Signed-off-by: Derek Ho <dxho@amazon.com> * Fix show datsources IT Signed-off-by: Derek Ho <dxho@amazon.com> * Remove files from merge Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 5ce1bab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #2200 +/- ##
=========================================
Coverage 96.59% 96.59%
Complexity 4752 4752
=========================================
Files 437 437
Lines 12693 12699 +6
Branches 859 859
=========================================
+ Hits 12261 12267 +6
Misses 422 422
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
penghuo
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5ce1bab from #2156.