Skip to content

Conversation

@srikanthpadakanti
Copy link
Contributor

@srikanthpadakanti srikanthpadakanti commented Jan 7, 2026

Description

This change introduces the mvcombine PPL command, which combines values of a specified field across rows that are identical on all other fields in the current result set.

mvcombine behaves as a pipeline-level grouping operator: it collapses matching rows into a single row and aggregates the target field values into a multivalue field, while preserving all non-target fields.

Command
mvcombine [delim=""]

Arguments

field (required)
The field whose values will be combined.

  • Must be a direct field reference.
  • Must be a single-valued (scalar) field.
  • If the field does not exist in the current schema, the command fails.

delim (optional)
Delimiter to be used when rendering a single-value representation of the combined field.

  • Defaults to a single space (" "), consistent with Splunk.
  • Accepted for forward compatibility.
  • Has no observable effect in this implementation, since nomv is not yet supported.

Semantics

mvcombine operates on the current result set.

Rows are grouped where all fields except have identical values.

For each group:

  • All non-target fields are preserved.
  • The target becomes a multivalue array containing the combined values.
  • Grouping is not limited to adjacent rows; all matching rows in the result set are combined.
  • Value order is preserved from the input stream order at the point where mvcombine executes.
  • Users must apply sort before mvcombine if deterministic ordering is required.
  • Rows missing the target field do not contribute a value to the combined output.
  • If the target field does not exist or is not a direct field reference, the command fails with an error.

Scope clarification

  • This PR implements multivalue output only, which is the default and primary behavior in Splunk.
  • nomv support (single-value string output using delim) is out of scope for this change and will be introduced separately.
  • The delim argument is parsed and validated for syntax parity and forward compatibility, but does not affect output in this implementation.

Related Issues

Resolves #4766
#4766

Check List

  • [ X] New functionality includes testing.
  • [ X] New functionality has been documented.
  • [ X] New functionality has javadoc added.
  • [ X] New functionality has a user manual doc added.
  • [ X] New PPL command checklist all confirmed.
  • [ X] API changes companion pull request created.
  • [ X] Commits are signed per the DCO using --signoff or -s.
  • [ X] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Srikanth Padakanti and others added 7 commits January 6, 2026 17:33
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Srikanth Padakanti added 4 commits January 27, 2026 12:38
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Srikanth Padakanti and others added 3 commits January 27, 2026 17:34
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>
Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
@srikanthpadakanti
Copy link
Contributor Author

@ykmr1224 @anasalkouz
I’m trying to get this change merged into the 3.5 release. Could you please run the workflows and let me know if you have any comments or concerns on the code?

Copy link
Collaborator

@yuancu yuancu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@LantaoJin LantaoJin merged commit 92e73ea into opensearch-project:main Jan 28, 2026
37 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19-dev failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-5025-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 92e73ead7c05c97668510de5cae246bdfdcff394
# Push it to GitHub
git push --set-upstream origin backport/backport-5025-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev

Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-5025-to-2.19-dev.

@LantaoJin
Copy link
Member

Thanks for your contribution, merged to main

asifabashar pushed a commit to asifabashar/sql that referenced this pull request Jan 28, 2026
* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add doctests to MvCombine

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessapply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add mvcombine to index.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* complete the checklist from ppl-commands.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessApply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add visitMvCombine method to the FieldResolutionVisitor

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Apply spotlesscheck

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add changes to exclude the metadata fields and remove the CAST logic

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

---------

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>
Co-authored-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
#	ppl/src/main/antlr/OpenSearchPPLParser.g4
asifabashar pushed a commit to asifabashar/sql that referenced this pull request Jan 28, 2026
* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add doctests to MvCombine

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessapply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add mvcombine to index.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* complete the checklist from ppl-commands.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessApply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add visitMvCombine method to the FieldResolutionVisitor

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Apply spotlesscheck

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add changes to exclude the metadata fields and remove the CAST logic

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

---------

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>
Co-authored-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
# Conflicts:
#	integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java
#	ppl/src/main/antlr/OpenSearchPPLParser.g4
LantaoJin pushed a commit to LantaoJin/search-plugins-sql that referenced this pull request Feb 2, 2026
* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add doctests to MvCombine

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessapply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add mvcombine to index.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* complete the checklist from ppl-commands.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessApply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add visitMvCombine method to the FieldResolutionVisitor

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Apply spotlesscheck

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add changes to exclude the metadata fields and remove the CAST logic

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

---------

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>
Co-authored-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
(cherry picked from commit 92e73ea)
LantaoJin pushed a commit to LantaoJin/search-plugins-sql that referenced this pull request Feb 2, 2026
* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add doctests to MvCombine

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessapply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add mvcombine to index.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* complete the checklist from ppl-commands.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessApply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add visitMvCombine method to the FieldResolutionVisitor

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Apply spotlesscheck

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add changes to exclude the metadata fields and remove the CAST logic

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

---------

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>
Co-authored-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
(cherry picked from commit 92e73ea)
@LantaoJin LantaoJin added the backport-manually Filed a PR to backport manually. label Feb 2, 2026
LantaoJin added a commit that referenced this pull request Feb 2, 2026
* Feature/mvcombine (#5025)

* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add doctests to MvCombine

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessapply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add mvcombine to index.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* complete the checklist from ppl-commands.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessApply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add visitMvCombine method to the FieldResolutionVisitor

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Apply spotlesscheck

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add changes to exclude the metadata fields and remove the CAST logic

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

---------

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>
Co-authored-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
(cherry picked from commit 92e73ea)

* Fix IT

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* Fix compile error

Signed-off-by: Lantao Jin <ltjin@amazon.com>

---------

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Srikanth Padakanti <srikanth29.9@gmail.com>
Co-authored-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add mvcombine command in PPL

4 participants