Skip to content

[Backport 2.19-dev] Feature/mvcombine (#5025)#5096

Merged
LantaoJin merged 4 commits intoopensearch-project:2.19-devfrom
LantaoJin:backport/backport-5025-to-2.19-dev_2
Feb 2, 2026
Merged

[Backport 2.19-dev] Feature/mvcombine (#5025)#5096
LantaoJin merged 4 commits intoopensearch-project:2.19-devfrom
LantaoJin:backport/backport-5025-to-2.19-dev_2

Conversation

@LantaoJin
Copy link
Member

(cherry picked from #5025 commit 92e73ea)

* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* MvCombine Command Feature

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add doctests to MvCombine

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlesscheck apply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessapply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address coderrabbit comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add mvcombine to index.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Remove the nomv related implementation as that command is still not yet implemented

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* complete the checklist from ppl-commands.md

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* spotlessApply

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add visitMvCombine method to the FieldResolutionVisitor

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Apply spotlesscheck

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Add changes to exclude the metadata fields and remove the CAST logic

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address CrossClusterSearchIT comment

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Coderrabbit issues

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

* Address comments

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

---------

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>
Co-authored-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
(cherry picked from commit 92e73ea)
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Lantao Jin <ltjin@amazon.com>
…rt-5025-to-2.19-dev_2

Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
@LantaoJin LantaoJin merged commit 2c46164 into opensearch-project:2.19-dev Feb 2, 2026
76 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants