-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Highlight In SQL #717
Add Highlight In SQL #717
Conversation
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
In particular, highlightField is an expression now. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
HighlightFunction is converted to LogicalHighlight logical plan. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
…Improved test coverage and fixing checkstyle errors. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
…ing coverage for OpenSearchIndexScan Signed-off-by: forestmvey <forestv@bitquilltech.com>
…light acceptance as a string literal as well as qualified name. Signed-off-by: forestmvey <forestv@bitquilltech.com>
…ht call in PhysicalPlanNodeVisitor.. Signed-off-by: forestmvey <forestv@bitquilltech.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering are we sending another PR for user manual separately?
opensearch/src/main/java/org/opensearch/sql/opensearch/storage/OpenSearchIndexScan.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/HighlightExpression.java
Show resolved
Hide resolved
…nction call in OpenSearchIndexScan. Signed-off-by: forestmvey <forestv@bitquilltech.com>
I added highlight to functions.rst under commit: 232b19f5924d2c46fd08b9d60abadb0d207ad016. Documentation website will be handled in a separate PR. |
…ght all and wildcard to unsupported to open up output formatting changes for multiple returned highlight fields. Change tests for updated coverage and disable highlight all and wildcard tests. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Under commit 9fbea3072bbf6cd3f89851a20344eecf720ac219 I have changed the output format to be more useable to the end user. See revisions to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
core/src/main/java/org/opensearch/sql/expression/HighlightExpression.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/HighlightExpression.java
Show resolved
Hide resolved
…ht fields Signed-off-by: forestmvey <forestv@bitquilltech.com>
d3af03b
to
23a24e2
Compare
…ression type. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Description
Support highlighting function in SQL query engine.
Issues Resolved
Github Issue: 636
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.