Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Highlight In SQL #717

Merged
merged 24 commits into from
Aug 5, 2022
Merged

Add Highlight In SQL #717

merged 24 commits into from
Aug 5, 2022

Commits on Jul 26, 2022

  1. Add support for highlight to parser and AstExpressionBuilder 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    1097d9f View commit details
    Browse the repository at this point in the history

  2. Add unit test for highlight in AstExpressionBuilder 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    1a453e1 View commit details
    Browse the repository at this point in the history

  3. Add unit test for highlight in AstBuilderTest 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    0d5c87b View commit details
    Browse the repository at this point in the history

  4. Support highlight as an Unresolved expression. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    26d0b7e View commit details
    Browse the repository at this point in the history

  5. Represent highlight as UnresolvedExpression. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    3f10b8b View commit details
    Browse the repository at this point in the history

  6. Support highlight in Analyzer. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    543d0d7 View commit details
    Browse the repository at this point in the history

  7. Treat highlight as a proper function in AST 

    In particular, highlightField is an expression now.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    f47ffe7 View commit details
    Browse the repository at this point in the history

  8. Add support for highlight in Analyzer 

    HighlightFunction is converted to LogicalHighlight logical plan.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    5fdb939 View commit details
    Browse the repository at this point in the history

  9. Add a simple IT test for highlight. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    5c8db0a View commit details
    Browse the repository at this point in the history

  10. Register highlight function in the BuiltInFunctionRepository 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    ac9f080 View commit details
    Browse the repository at this point in the history

  11. Partial support for highlight in physical plan. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    b526132 View commit details
    Browse the repository at this point in the history

  12. Add HighlightOperator. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    807c475 View commit details
    Browse the repository at this point in the history

  13. Highlight alpha complete. 

    Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
    @forestmvey
    MaxKsyunz authored and forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    74b6492 View commit details
    Browse the repository at this point in the history

  14. Initial implementation to upporting highlight('*') 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    ad7affc View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Add support for multiple highlight calls in select statement. 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    bb97dde View commit details
    Browse the repository at this point in the history

  2. Removed OpenSearchLogicalIndexScan highlightFields and dependencies. … 

    …Improved test coverage and fixing checkstyle errors.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    163b909 View commit details
    Browse the repository at this point in the history

  3. Added HighlightExpressionTest 

    Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    b2a90d4 View commit details
    Browse the repository at this point in the history

  4. Added javadocs, minor PR revisions, and fixed jacoco errors by improv… 

    …ing coverage for OpenSearchIndexScan

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    2c04c49 View commit details
    Browse the repository at this point in the history

  5. Code cleanup, adding parsing failure tests, and adding tests for high… 

    …light acceptance as a string literal as well as qualified name.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    01708e3 View commit details
    Browse the repository at this point in the history

  6. Removing HighlightOperator functionality and unnecessary visitHighlig… 

    …ht call in PhysicalPlanNodeVisitor..

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    6b96ac0 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Adding highlight function to functions.rst and removing unecessary fu… 

    …nction call in OpenSearchIndexScan.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    232b19f View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Change highlight fields returned format to array list. Changed highli… 

    …ght all and wildcard to unsupported to open up output formatting changes for multiple returned highlight fields. Change tests for updated coverage and disable highlight all and wildcard tests.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    9fbea30 View commit details
    Browse the repository at this point in the history

  2. Fix bug where invalid schema name was being used for returned highlig… 

    …ht fields

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    23a24e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Fix failing integration tests due to schema changes for highlight exp… 

    …ression type.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
    @forestmvey
    forestmvey committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    449a330 View commit details
    Browse the repository at this point in the history