Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Enable sidecar injection by default for namespaces being enrolled into the mesh #1896

Closed
shashankram opened this issue Oct 22, 2020 · 1 comment
Assignees
Labels
area/cli Related to OSM CLI
Milestone

Comments

@shashankram
Copy link
Member

Please describe the Improvement and/or Feature Request
Currently, when a namespace is added to the mesh using the osm namespace add command, sidecar injection is not enabled by default unless the --enable-sidecar-injection flag is passed. This was done based on the requirement that enabling sidecar injection on a namespace could be destructive for new users.

However, this proves to be a bit counterintuitive because the common use case is to enroll a namespace into the mesh and have it injected with sidecars to participate in the mesh.

Scope (please mark with X where applicable)

  • New Functionality [ ]
  • Install [ ]
  • SMI Traffic Access Policy [ ]
  • SMI Traffic Specs Policy [ ]
  • SMI Traffic Split Policy [ ]
  • Permissive Traffic Policy [ ]
  • Ingress [ ]
  • Egress [ ]
  • Envoy Control Plane [ ]
  • CLI Tool [X]
  • Metrics [ ]
  • Certificate Management [ ]
  • Sidecar Injection [ ]
  • Logging [ ]
  • Debugging [ ]
  • Tests [ ]
  • CI System [ ]
  • Project Release [ ]

Possible use cases

This issue is to propose enabling sidecar injection by default with the osm namespace add command, unless --disable-sidecar-injection flag is passed. There are other ways to prevent a namespace from being injected with sidecars and controlling injection on a per pod basis, that make it more reasonable to have the namespace scoped injection enabled by default with the osm namespace add command.

@shashankram shashankram added P2 area/cli Related to OSM CLI labels Oct 22, 2020
@shashankram shashankram self-assigned this Oct 22, 2020
shashankram added a commit to shashankram/osm that referenced this issue Oct 22, 2020
Based on usability feedback, we want sidecar injection to be enabled
by default with the `osm namespace add` command. This change flips
the flag to `--disable-sidecar-injection` to explicitly disable
sidecar injection only if the flag is specified.

Refer to openservicemesh#1896 for more details.
shashankram added a commit that referenced this issue Oct 22, 2020
…1901)

Based on usability feedback, we want sidecar injection to be enabled
by default with the `osm namespace add` command. This change flips
the flag to `--disable-sidecar-injection` to explicitly disable
sidecar injection only if the flag is specified.

Refer to #1896 for more details.
@shashankram shashankram added this to the v0.6.0 milestone Oct 23, 2020
@shashankram
Copy link
Member Author

Resolved by c5147ae

draychev pushed a commit to draychev/osm that referenced this issue Oct 28, 2020
…penservicemesh#1901)

Based on usability feedback, we want sidecar injection to be enabled
by default with the `osm namespace add` command. This change flips
the flag to `--disable-sidecar-injection` to explicitly disable
sidecar injection only if the flag is specified.

Refer to openservicemesh#1896 for more details.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to OSM CLI
Projects
None yet
Development

No branches or pull requests

1 participant