This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
cli: enable sidecar injection by default with namespace add command #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on usability feedback, we want sidecar injection to be enabled by default with the `osm namespace add` command. This change flips the flag to `--disable-sidecar-injection` to explicitly disable sidecar injection only if the flag is specified. Refer to openservicemesh#1896 for more details.
eduser25
approved these changes
Oct 22, 2020
snehachhabria
approved these changes
Oct 22, 2020
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
…penservicemesh#1901) Based on usability feedback, we want sidecar injection to be enabled by default with the `osm namespace add` command. This change flips the flag to `--disable-sidecar-injection` to explicitly disable sidecar injection only if the flag is specified. Refer to openservicemesh#1896 for more details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Based on usability feedback, we want sidecar injection to be enabled
by default with the
osm namespace addcommand. This change flipsthe flag to
--disable-sidecar-injectionto explicitly disablesidecar injection only if the flag is specified.
Refer to #1896 for more details.
Affected area:
Please answer the following questions with yes/no.