Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

test(pkg/utils): Check errors generically for NewGrpc test #1790

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

ksubrmnn
Copy link
Contributor

@ksubrmnn ksubrmnn commented Oct 5, 2020

Description:
Check if an error occurs in NewGrpc tests instead of checking contents of errors. This will handle various types of errors that may occur due to different runtime environments.

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [X]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

No

@ksubrmnn ksubrmnn requested a review from a team as a code owner October 5, 2020 21:41
@ksubrmnn ksubrmnn changed the title test(pkg/utils): Check if error occured for NewGrpc test(pkg/utils): Check error generically for NewGrpc test Oct 5, 2020
@ksubrmnn ksubrmnn changed the title test(pkg/utils): Check error generically for NewGrpc test test(pkg/utils): Check errors generically for NewGrpc test Oct 5, 2020
@ksubrmnn ksubrmnn merged commit c409556 into openservicemesh:main Oct 5, 2020
@ksubrmnn ksubrmnn deleted the utils branch October 5, 2020 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants